-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more automated tests to 9. Sharing #724
Conversation
2f72b7a
to
3fb01f7
Compare
38 :robot: | Share a folder with user B without Create permissions enabled. Login as User B and try to create a file in it | The folder cannot be edited creating a file in it | :heavy_check_mark: | tst_sharing | | ||
39 :robot: | Share a folder with user B without Change permissions enabled. Login as User B and try to change it | The folder cannot be changed | :heavy_check_mark: | tst_sharing | | ||
40 :robot: | Share a folder with user B without Delete permissions enabled. Login as User B and try to delete it | The folder cannot be edited deleting files/folders in it | :heavy_check_mark: | tst_sharing | | ||
41 :robot: | With Password Policy App enabled, Share link a file with a user and set a password that matches with the pwd policy | The file is shared with pwd |:heavy_check_mark:| tst_sharing | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that we have any test enabling password policy. Do you know any @saw-jan ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that we have any test enabling password policy. Do you know any @saw-jan ?
These tests are marked as automated in the 2.10.0 test plan owncloud/client#9290
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do have test for sharing public link with password protection but the test doesn't set any password policy on the server.
May be we misunderstood this test case and marked as automated.
If changing password policy on the server needs to be part of the test then we can automated this test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will remove the robot from 9.2/38 - 41 for now and check which tests are needed.
@Talank I have just noticed added test for long file name with a test for a file with a length of 224 chars which is supposed to work (scenario 3/5 "Long file name"). |
@gabi18 I think the >=233 test was somewhere in VFS testplan 🤔 I remembered that 233 was special somehow. I don't think it was in release testplan. Can you add it though? And you can mark it automated in the PR owncloud/client#9398 |
I have added the long file name test here as 3/6. The test in VFS testplan is about a long path name and related to placeholder creation. If you agree I will merge this pull request now. And then mark all automated 'Files' tests in an extra step as soon as owncloud/client#9396 is finished. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depends on owncloud/client#9398
Technically, I approve here, but please clarify the status of the above PR before merging here. 👍
thanks! We want to be precise! Co-authored-by: Talank <[email protected]>
@saw-jan Could you please re-check 9.2 38/39/40 - should be already automated. I have removed 9.2/40+41 from the test plan, 9.1/24 already includes the tests with Password Policy server app. |
the PR to add automated tests for long named files has been moved to owncloud/client#9458 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tests marked as automated on owncloud/client#9290 applied to template.