feat: passcode not focusable to keep the same behaviour between custo…

…m keyboard and external keyboard
owncloud · Sep 18, 2024 · cfb5229 · cfb5229
1 parent 4d14f3a
commit cfb5229
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/...udApp/src/main/java/com/owncloud/android/presentation/security/passcode/NumberKeyboard.kt b/...udApp/src/main/java/com/owncloud/android/presentation/security/passcode/NumberKeyboard.kt
@@ -2,7 +2,9 @@
  * ownCloud Android client application
  *
  * @author David Crespo Ríos
- * Copyright (C) 2022 ownCloud GmbH.
+ * @author Aitor Ballesteros Pavón
+ *
+ * Copyright (C) 2024 ownCloud GmbH.
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 2,
@@ -71,6 +73,12 @@ class NumberKeyboard(context: Context, attrs: AttributeSet) : ConstraintLayout(c
         setupListeners()
     }
 
+    fun setFocusOnKey(number: Int) {
+        if (number in 0..9) {
+            numericKeys[number].requestFocus()
+        }
+    }
+
     /**
      * Setup on click listeners.
      */

diff --git a/...App/src/main/java/com/owncloud/android/presentation/security/passcode/PassCodeActivity.kt b/...App/src/main/java/com/owncloud/android/presentation/security/passcode/PassCodeActivity.kt
@@ -478,6 +478,7 @@ class PassCodeActivity : AppCompatActivity(), NumberKeyboardListener, EnableBiom
             in KeyEvent.KEYCODE_0..KeyEvent.KEYCODE_9 -> {
                 val number = keyCode - KeyEvent.KEYCODE_0
                 passCodeViewModel.onNumberClicked(number)
+                binding.numberKeyboard.setFocusOnKey(number)
                 true
             }
 

diff --git a/owncloudApp/src/main/res/layout/passcode_edit_text.xml b/owncloudApp/src/main/res/layout/passcode_edit_text.xml
@@ -5,4 +5,5 @@
     style="@style/PassCodeStyle"
     android:cursorVisible="true"
     android:layout_width="32dp"
-    android:imeOptions="flagNoExtractUi"/>
+    android:imeOptions="flagNoExtractUi"
+    android:focusable="false"/>