Merge pull request #4429 from owncloud/feature/contrast_minimum_acces…

…ibility [a11y] 11.1.4.3 Contrast (minimum)
owncloud · Jul 3, 2024 · fab7a1e · fab7a1e
2 parents b0e7a21 + a6ce315
commit fab7a1e
Show file tree

Hide file tree

Showing 21 changed files with 42 additions and 409 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,6 @@
 # Table of Contents
 
+* [Changelog for unreleased](#changelog-for-owncloud-android-client-unreleased-unreleased)
 * [Changelog for 4.3.0](#changelog-for-owncloud-android-client-430-2024-07-01)
 * [Changelog for 4.2.2](#changelog-for-owncloud-android-client-422-2024-05-30)
 * [Changelog for 4.2.1](#changelog-for-owncloud-android-client-421-2024-02-22)
@@ -21,6 +22,27 @@
 * [Changelog for 2.18.1](#changelog-for-owncloud-android-client-2181-2021-07-20)
 * [Changelog for 2.18.0](#changelog-for-owncloud-android-client-2180-2021-05-24)
 * [Changelog for 2.17 versions and below](#changelog-for-217-versions-and-below)
+# Changelog for ownCloud Android Client [unreleased] (UNRELEASED)
+
+The following sections list the changes in ownCloud Android Client unreleased relevant to
+ownCloud admins and users.
+
+[unreleased]: https://github.com/owncloud/android/compare/v4.3.0...master
+
+## Summary
+
+* Enhancement - Changed the color of some elements to improve accessibility: [#4364](https://github.com/owncloud/android/issues/4364)
+
+## Details
+
+* Enhancement - Changed the color of some elements to improve accessibility: [#4364](https://github.com/owncloud/android/issues/4364)
+
+   The color of some UI elements has been changed to meet minimum color contrast
+   requirements.
+
+   https://github.com/owncloud/android/issues/4364
+   https://github.com/owncloud/android/pull/4429
+
 # Changelog for ownCloud Android Client [4.3.0] (2024-07-01)
 
 The following sections list the changes in ownCloud Android Client 4.3.0 relevant to

diff --git a/changelog/unreleased/4429 b/changelog/unreleased/4429
@@ -0,0 +1,6 @@
+Enhancement: Changed the color of some elements to improve accessibility
+
+The color of some UI elements has been changed to meet minimum color contrast requirements.
+
+https://github.com/owncloud/android/issues/4364
+https://github.com/owncloud/android/pull/4429
diff --git a/...App/src/main/java/com/owncloud/android/presentation/releasenotes/ReleaseNotesViewModel.kt b/...App/src/main/java/com/owncloud/android/presentation/releasenotes/ReleaseNotesViewModel.kt
@@ -45,109 +45,14 @@ class ReleaseNotesViewModel(
 
     companion object {
         val releaseNotesList = listOf(
-            ReleaseNote(
-                title = R.string.release_notes_4_3_0_title_new_ui_manage_accounts,
-                subtitle = R.string.release_notes_4_3_0_subtitle_new_ui_manage_accounts,
-                type = ReleaseNoteType.ENHANCEMENT
-            ),
-            ReleaseNote(
-                title = R.string.release_notes_4_3_0_title_create_open_shortcut,
-                subtitle = R.string.release_notes_4_3_0_subtitle_create_open_shortcut,
-                type = ReleaseNoteType.ENHANCEMENT
-            ),
-            ReleaseNote(
-                title = R.string.release_notes_4_3_0_title_1,
-                subtitle = R.string.release_notes_4_3_0_subtitle_1,
-                type = ReleaseNoteType.ENHANCEMENT,
-            ),
-            ReleaseNote(
-                title = R.string.release_notes_4_3_0_title_2,
-                subtitle = R.string.release_notes_4_3_0_subtitle_2,
-                type = ReleaseNoteType.ENHANCEMENT,
-            ),
-            ReleaseNote(
-                title = R.string.release_notes_4_3_0_title_manual_removal_local_storage,
-                subtitle = R.string.release_notes_4_3_0_subtitle_manual_removal_local_storage,
-                type = ReleaseNoteType.ENHANCEMENT,
-            ),
-            ReleaseNote(
-                title = R.string.release_notes_4_3_0_title_password_generator,
-                subtitle = R.string.release_notes_4_3_0_subtitle_password_generator,
-                type = ReleaseNoteType.ENHANCEMENT
-            ),
-            ReleaseNote(
-                title = R.string.release_notes_4_3_0_title_report_feedback_central_github,
-                subtitle = R.string.release_notes_4_3_0_subtitle_report_feedback_central_github,
-                type = ReleaseNoteType.ENHANCEMENT
-            ),
-            ReleaseNote(
-                title = R.string.release_notes_4_3_0_title_clear_data_button_hard_reset,
-                subtitle = R.string.release_notes_4_3_0_subtitle_clear_data_button_hard_reset,
-                type = ReleaseNoteType.BUGFIX,
-            ),
-            ReleaseNote(
-                title = R.string.release_notes_4_3_0_title_4,
-                subtitle = R.string.release_notes_4_3_0_subtitle_4,
-                type = ReleaseNoteType.ENHANCEMENT,
-            ),
-            ReleaseNote(
-                title = R.string.release_notes_4_3_0_title_5,
-                subtitle = R.string.release_notes_4_3_0_subtitle_5,
-                type = ReleaseNoteType.BUGFIX,
-            ),
-            ReleaseNote(
-                title = R.string.release_notes_4_3_0_title_6,
-                subtitle = R.string.release_notes_4_3_0_subtitle_6,
-                type = ReleaseNoteType.ENHANCEMENT,
-            ),
-            ReleaseNote(
-                title = R.string.release_notes_4_3_0_title_7,
-                subtitle = R.string.release_notes_4_3_0_subtitle_7,
-                type = ReleaseNoteType.ENHANCEMENT
-            ),
-            ReleaseNote(
-                title = R.string.release_notes_4_3_0_title_retried_successful_uploads_delete_temporary_folder,
-                subtitle = R.string.release_notes_4_3_0_subtitle_retried_successful_uploads_delete_temporary_folder,
-                type = ReleaseNoteType.BUGFIX,
-            ),
-            ReleaseNote(
-                title = R.string.release_notes_4_3_0_title_improvements_remove_dialog,
-                subtitle = R.string.release_notes_4_3_0_subtitle_improvements_remove_dialog,
-                type = ReleaseNoteType.ENHANCEMENT
-            ),
-            ReleaseNote(
-                title = R.string.release_notes_4_3_0_title_display_name_truncation,
-                subtitle = R.string.release_notes_4_3_0_subtitle_display_name_truncation,
-                type = ReleaseNoteType.BUGFIX
-            ),
-            ReleaseNote(
-                title = R.string.release_notes_4_3_0_title_improve_available_offline_performance,
-                subtitle = R.string.release_notes_4_3_0_subtitle_improve_available_offline_performance,
-                type = ReleaseNoteType.ENHANCEMENT
-            ),
-            ReleaseNote(
-                title = R.string.release_notes_4_3_0_title_search_functionality_in_spaces_list,
-                subtitle = R.string.release_notes_4_3_0_subtitle_search_functionality_in_spaces_list,
-                type = ReleaseNoteType.ENHANCEMENT
-            ),
-            ReleaseNote(
-                title = R.string.release_notes_4_3_0_title_video_streaming_spaces,
-                subtitle = R.string.release_notes_4_3_0_subtitle_video_streaming_spaces,
-                type = ReleaseNoteType.BUGFIX
-            ),
             ReleaseNote(
                 title = R.string.release_notes_4_3_0_title_accessibility_improvements,
                 subtitle = R.string.release_notes_4_3_0_subtitle_accessibility_improvements,
                 type = ReleaseNoteType.ENHANCEMENT
             ),
             ReleaseNote(
-                title = R.string.release_notes_4_3_0_title_show_app_provider_icon_from_endpoint,
-                subtitle = R.string.release_notes_4_3_0_subtitle_show_app_provider_icon_from_endpoint,
-                type = ReleaseNoteType.ENHANCEMENT
-            ),
-            ReleaseNote(
-                title = R.string.release_notes_4_3_0_title_av_offline_files_removed_locally_with_local_only_option,
-                subtitle = R.string.release_notes_4_3_0_subtitle_av_offline_files_removed_locally_with_local_only_option,
+                title = R.string.release_notes_bugfixes_title,
+                subtitle = R.string.release_notes_bugfixes_subtitle,
                 type = ReleaseNoteType.BUGFIX
             ),
         )

diff --git a/owncloudApp/src/main/res/layout-land/nav_drawer_footer.xml b/owncloudApp/src/main/res/layout-land/nav_drawer_footer.xml
@@ -69,6 +69,7 @@
         android:layout_width="0dp"
         android:layout_height="wrap_content"
         android:text="@string/drawer_loading_quota"
+        android:textColor="@color/list_item_lastmod_and_filesize_text"
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toBottomOf="@id/account_quota_bar" />

diff --git a/owncloudApp/src/main/res/layout/files_folder_picker.xml b/owncloudApp/src/main/res/layout/files_folder_picker.xml
@@ -39,6 +39,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
         android:background="@color/warning_background_color"
         android:visibility="gone"
         android:text="@string/folder_picker_no_permissions_message_text"
+        android:textColor="@color/warning_grey_text"
         tools:visibility="visible"/>
 
     <ImageView

diff --git a/owncloudApp/src/main/res/layout/list_footer.xml b/owncloudApp/src/main/res/layout/list_footer.xml
@@ -15,7 +15,7 @@
         android:padding="@dimen/standard_padding"
         android:layout_gravity="center"
         android:gravity="center"
-        android:textColor="@color/secondaryTextColor"
+        android:textColor="@color/list_item_lastmod_and_filesize_text"
         android:layout_marginBottom="56dp"
         />
 

diff --git a/owncloudApp/src/main/res/layout/nav_drawer_footer.xml b/owncloudApp/src/main/res/layout/nav_drawer_footer.xml
@@ -81,6 +81,7 @@
         android:layout_width="0dp"
         android:layout_height="wrap_content"
         android:text="@string/drawer_loading_quota"
+        android:textColor="@color/list_item_lastmod_and_filesize_text"
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toBottomOf="@id/account_quota_bar" />

diff --git a/owncloudApp/src/main/res/layout/share_file_layout.xml b/owncloudApp/src/main/res/layout/share_file_layout.xml
@@ -63,6 +63,7 @@
                 android:layout_marginStart="4dp"
                 android:layout_toEndOf="@+id/shareFileIcon"
                 android:text="@string/placeholder_filesize"
+                android:textColor="@color/list_item_lastmod_and_filesize_text"
                 android:textSize="12sp" />
 
             <ImageButton
@@ -181,6 +182,7 @@
                 android:paddingRight="@dimen/standard_half_padding"
                 android:paddingTop="@dimen/standard_padding"
                 android:text="@string/share_warning_about_forwarding_public_links"
+                android:textColor="@color/warning_grey_text"
                 android:textSize="15sp" />
 
             <ListView

diff --git a/owncloudApp/src/main/res/layout/share_public_dialog.xml b/owncloudApp/src/main/res/layout/share_public_dialog.xml
@@ -302,6 +302,7 @@
                     android:paddingLeft="@dimen/standard_half_padding"
                     android:paddingRight="@dimen/standard_half_padding"
                     android:textSize="12sp"
+                    android:textColor="@color/list_item_lastmod_and_filesize_text"
                     android:visibility="gone" />
 
                 <TextView

diff --git a/owncloudApp/src/main/res/layout/uploader_layout.xml b/owncloudApp/src/main/res/layout/uploader_layout.xml
@@ -78,6 +78,7 @@
             android:paddingHorizontal="@dimen/standard_padding"
             android:paddingVertical="@dimen/standard_half_padding"
             android:text="@string/folder_picker_no_permissions_message_text"
+            android:textColor="@color/warning_grey_text"
             android:visibility="gone"
             tools:visibility="visible" />
 

diff --git a/owncloudApp/src/main/res/values-de-rDE/strings.xml b/owncloudApp/src/main/res/values-de-rDE/strings.xml
@@ -665,10 +665,6 @@
   <string name="release_notes_footer">Vielen Dank für die Verwendung von %1$s.\n</string>
   <string name="release_notes_proceed">Fortfahren</string>
   <string name="release_notes_icon">Symbol für Veröffentlichungsnotizen</string>
-  <string name="release_notes_4_3_0_title_1">Neue Einstellung zum automatischen Entfernen heruntergeladener Dateien, welche eine bestimmte Zeit lang nicht verwendet wurden</string>
-  <string name="release_notes_4_3_0_subtitle_1">Im Abschnitt „Erweitert“ wurde eine neue Einstellung hinzugefügt, um automatisch heruntergeladene Dateien zu löschen, wenn die Zeit seit ihrer letzten Verwendung die in der Einstellung ausgewählte Zeit überschreitet</string>
-  <string name="release_notes_4_3_0_title_2">Automatische Konto Erkennung beim Login</string>
-  <string name="release_notes_4_3_0_subtitle_2">Die Schaltfläche zum Aktualisieren des Kontos wurde in der Ansicht „Konten verwalten“ entfernt, da die automatische Kontoerkennung beim Anmelden erfolgt</string>
   <!--Open in web-->
   <string name="ic_action_open_in_web">Öffnen im Webbrowser</string>
   <string name="ic_action_open_with_web">Öffnen in %1$s (web)</string>

diff --git a/owncloudApp/src/main/res/values-de/strings.xml b/owncloudApp/src/main/res/values-de/strings.xml
@@ -664,10 +664,6 @@
   <string name="release_notes_footer">Vielen Dank für die Verwendung von %1$s.\n</string>
   <string name="release_notes_proceed">Fortfahren</string>
   <string name="release_notes_icon">Icon für Veröffentlichungsnotizen</string>
-  <string name="release_notes_4_3_0_title_1">Neue Einstellung zum automatischen Entfernen heruntergeladener Dateien, welche eine bestimmte Zeit lang nicht verwendet wurden</string>
-  <string name="release_notes_4_3_0_subtitle_1">Im Abschnitt „Erweitert“ wurde eine neue Einstellung hinzugefügt, um automatisch heruntergeladene Dateien zu löschen, wenn die Zeit seit ihrer letzten Verwendung die in der Einstellung ausgewählte Zeit überschreitet</string>
-  <string name="release_notes_4_3_0_title_2">Automatische Konto Erkennung beim Login</string>
-  <string name="release_notes_4_3_0_subtitle_2">Die Schaltfläche zum Aktualisieren des Kontos wurde in der Ansicht „Konten verwalten“ entfernt, da die automatische Kontoerkennung beim Anmelden erfolgt</string>
   <!--Open in web-->
   <string name="ic_action_open_in_web">Öffnen im Webbrowser</string>
   <string name="ic_action_open_with_web">Öffnen in %1$s (web)</string>