Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TECHNICAL] Unit tests for datasources classes - Part 3 #4143

Merged
merged 20 commits into from
Oct 17, 2023
Merged

[TECHNICAL] Unit tests for datasources classes - Part 3 #4143

merged 20 commits into from
Oct 17, 2023

Conversation

Aitorbp
Copy link
Contributor

@Aitorbp Aitorbp commented Aug 29, 2023 •
edited by JuancaG05
Loading

Related Issues

App:

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

@Aitorbp Aitorbp self-assigned this Aug 29, 2023
@Aitorbp Aitorbp linked an issue Aug 29, 2023 that may be closed by this pull request
[TECHNICAL] Unit tests for datasources classes - Part 3 #4072
Closed
18 tasks
JuancaG05
JuancaG05 requested changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many things to check here @Aitorbp! Little by little 👍

changelog/unreleased/4143 Outdated Show resolved Hide resolved
changelog/unreleased/4143 Outdated Show resolved Hide resolved
...java/com/owncloud/android/data/spaces/datasources/implementation/OCRemoteSpacesDataSource.kt Outdated Show resolved Hide resolved
...ud/android/data/folderbackup/datasources/implementation/OCFolderBackupLocalDataSourceTest.kt Outdated Show resolved Hide resolved
...ud/android/data/folderbackup/datasources/implementation/OCFolderBackupLocalDataSourceTest.kt Outdated Show resolved Hide resolved
...dData/src/test/java/com/owncloud/android/data/user/datasources/OCRemoteUserDataSourceTest.kt Show resolved Hide resolved
...owncloud/android/data/webfinger/datasource/implementation/OCRemoteWebFingerDatasourceTest.kt Outdated Show resolved Hide resolved
...owncloud/android/data/webfinger/datasource/implementation/OCRemoteWebFingerDatasourceTest.kt Outdated Show resolved Hide resolved
...owncloud/android/data/webfinger/datasource/implementation/OCRemoteWebFingerDatasourceTest.kt Outdated Show resolved Hide resolved
...owncloud/android/data/webfinger/datasource/implementation/OCRemoteWebFingerDatasourceTest.kt Show resolved Hide resolved
@Aitorbp Aitorbp requested a review from JuancaG05 October 5, 2023 09:49
JuancaG05
JuancaG05 requested changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second round of CR here @Aitorbp!

owncloudData/src/main/java/com/owncloud/android/data/transfers/db/OCTransferEntity.kt Outdated Show resolved Hide resolved
...loud/android/data/appRegistry/datasources/implementation/OCLocalAppRegistryDataSourceTest.kt Outdated Show resolved Hide resolved
...oud/android/data/appRegistry/datasources/implementation/OCRemoteAppRegistryDataSourceTest.kt Outdated Show resolved Hide resolved
...dData/src/test/java/com/owncloud/android/data/oauth/datasources/RemoteOAuthDataSourceTest.kt Outdated Show resolved Hide resolved
...est/java/com/owncloud/android/data/transfers/implementation/OCLocalTransferDataSourceTest.kt Outdated Show resolved Hide resolved
...dData/src/test/java/com/owncloud/android/data/user/datasources/OCRemoteUserDataSourceTest.kt Outdated Show resolved Hide resolved
...owncloud/android/data/webfinger/datasource/implementation/OCRemoteWebFingerDatasourceTest.kt Outdated Show resolved Hide resolved
...owncloud/android/data/webfinger/datasource/implementation/OCRemoteWebFingerDatasourceTest.kt Outdated Show resolved Hide resolved
owncloudTestUtil/build.gradle Outdated Show resolved Hide resolved
owncloudTestUtil/build.gradle Outdated Show resolved Hide resolved
@Aitorbp Aitorbp requested a review from JuancaG05 October 9, 2023 10:48
JuancaG05
JuancaG05 requested changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more round of CR here @Aitorbp 🚀

...ndroid/data/authentication/datasources/implementation/OCLocalAuthenticationDataSourceTest.kt Outdated Show resolved Hide resolved
...ata/src/test/java/com/owncloud/android/data/shares/datasources/OCLocalShareDataSourceTest.kt Outdated Show resolved Hide resolved
...ata/src/test/java/com/owncloud/android/data/shares/datasources/OCLocalShareDataSourceTest.kt Outdated Show resolved Hide resolved
...ata/src/test/java/com/owncloud/android/data/shares/datasources/OCLocalShareDataSourceTest.kt Outdated Show resolved Hide resolved
...ta/src/test/java/com/owncloud/android/data/shares/datasources/OCRemoteShareDataSourceTest.kt Outdated Show resolved Hide resolved
...est/java/com/owncloud/android/data/transfers/implementation/OCLocalTransferDataSourceTest.kt Outdated Show resolved Hide resolved
...est/java/com/owncloud/android/data/transfers/implementation/OCLocalTransferDataSourceTest.kt Outdated Show resolved Hide resolved
...est/java/com/owncloud/android/data/transfers/implementation/OCLocalTransferDataSourceTest.kt Outdated Show resolved Hide resolved
...est/java/com/owncloud/android/data/transfers/implementation/OCLocalTransferDataSourceTest.kt Outdated Show resolved Hide resolved
...owncloud/android/data/webfinger/datasource/implementation/OCRemoteWebFingerDatasourceTest.kt Outdated Show resolved Hide resolved
@Aitorbp Aitorbp requested a review from JuancaG05 October 13, 2023 06:38
JuancaG05
JuancaG05 requested changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last changes here @Aitorbp! You can also do the renaming you have pending from the first CR now

...ndroid/data/authentication/datasources/implementation/OCLocalAuthenticationDataSourceTest.kt Show resolved Hide resolved
...ata/src/test/java/com/owncloud/android/data/shares/datasources/OCLocalShareDataSourceTest.kt Outdated Show resolved Hide resolved
@Aitorbp Aitorbp force-pushed the technical/testing_datasources_3 branch from a7caf0e to 4dcaa14 Compare October 16, 2023 12:19
JuancaG05
JuancaG05 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally approved! Great great work here @Aitorbp 🥇

@JuancaG05 JuancaG05 force-pushed the technical/testing_datasources_3 branch from c437b4e to 475412b Compare October 17, 2023 15:34
@JuancaG05 JuancaG05 merged commit 9bbef94 into master Oct 17, 2023
2 checks passed
@JuancaG05 JuancaG05 deleted the technical/testing_datasources_3 branch October 17, 2023 16:05
jesmrec pushed a commit that referenced this pull request Oct 20, 2023
@JuancaG05 @jesmrec
Merge pull request #4143 from owncloud/technical/testing_datasources_3
3cd8159 
[TECHNICAL] Unit tests for datasources classes - Part 3
Aitorbp pushed a commit that referenced this pull request Feb 5, 2024
@JuancaG05 @Aitorbp
Merge pull request #4143 from owncloud/technical/testing_datasources_3
884088f 
[TECHNICAL] Unit tests for datasources classes - Part 3
@JuancaG05 JuancaG05 mentioned this pull request Feb 7, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuancaG05 JuancaG05 JuancaG05 approved these changes

Assignees

@Aitorbp Aitorbp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TECHNICAL] Unit tests for datasources classes - Part 3
2 participants
@Aitorbp @JuancaG05