Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.1.0_oem #4161

Merged
merged 2 commits into from
Sep 21, 2023
Merged

4.1.0_oem #4161

merged 2 commits into from
Sep 21, 2023

Conversation

jesmrec
Copy link
Collaborator

@jesmrec jesmrec commented Sep 20, 2023

Related Issues

App: #4137

Library PR (if needed):

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

@jesmrec jesmrec changed the base branch from stable to master September 20, 2023 11:05
@jesmrec jesmrec changed the base branch from master to stable September 20, 2023 11:05
@JuancaG05 JuancaG05 linked an issue Sep 20, 2023 that may be closed by this pull request
[RELEASE] 4.1.0_oem #4137
Closed
17 tasks
JuancaG05
JuancaG05 approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jesmrec
Copy link
Collaborator Author

jesmrec commented Sep 20, 2023 •
edited
Loading

This PR to be merged into stable without the UI tests passed. The following tests:

Screenshot 2023-09-20 at 18 07 54

were already fixed by @Aitorbp after latest release and fix is available in master. I did not finally cherry-pick those commits in order not to add noise to the stable branch after the signed tag.

@JuancaG05 @manuelplazaspalacio @Aitorbp is this OK for you? once the PR is rebased with master to merge the changes of stable, the problem is straight fixed.

@JuancaG05
Copy link
Collaborator

Yeah it's OK for me, go forward! 😺

@jesmrec jesmrec merged commit 50cdb8a into stable Sep 21, 2023
4 checks passed
@jesmrec jesmrec deleted the release/4.1.0_oem branch September 21, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuancaG05 JuancaG05 JuancaG05 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RELEASE] 4.1.0_oem
3 participants
@jesmrec @JuancaG05 @manuelplazaspalacio