Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] NPEs in FileDetailsFragment (Play Store) #4170

Closed
wants to merge 350 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
350 commits
Select commit Hold shift + click to select a range
ad3a928
Added calens file
JuancaG05 Jun 13, 2023
6b80f22
Calens changelog updated
JuancaG05 Jun 13, 2023
2f49cb7
Calens changelog updated
JuancaG05 Jun 14, 2023
1e846b0
Showing decision dialog when copying file conflict.
manuelplazaspalacio May 31, 2023
bd9d48c
Showing decision dialog when moving file conflict.
manuelplazaspalacio Jun 6, 2023
3f9d482
Refactor getting path when copying and moving files.
manuelplazaspalacio Jun 6, 2023
2a056b7
Solving test errors.
manuelplazaspalacio Jun 6, 2023
f5c3795
Adding new test to copying and moving files use cases.
manuelplazaspalacio Jun 7, 2023
d82201c
Adding changelog #3935.
manuelplazaspalacio Jun 7, 2023
714a3f1
Change name changelog to #4062.
manuelplazaspalacio Jun 7, 2023
c8ae525
Change library reference.
manuelplazaspalacio Jun 7, 2023
b34476f
Modifying changelog.
manuelplazaspalacio Jun 7, 2023
dbe22b5
Calens changelog updated
manuelplazaspalacio Jun 7, 2023
f370bb4
Cleaning MoveFileUseCase code.
manuelplazaspalacio Jun 7, 2023
1ad4e91
Solving CR changes.
manuelplazaspalacio Jun 8, 2023
d62aba7
Solving CR changes.
manuelplazaspalacio Jun 13, 2023
454e178
- Changing text on dialog when copying/moving conflict.
manuelplazaspalacio Jun 15, 2023
cf8fd2b
Calens changelog updated
manuelplazaspalacio Jun 15, 2023
7e319e7
[tx] updated from transifex
ownclouders Jun 22, 2023
248f80d
[tx] updated from transifex
ownclouders Jun 23, 2023
cfac432
[tx] updated from transifex
ownclouders Jun 27, 2023
87de7c5
[tx] updated from transifex
ownclouders Jul 2, 2023
f51321a
[tx] updated from transifex
ownclouders Jul 5, 2023
72cb5e6
Take into account in menu filter just files which are av. offline, no…
JuancaG05 Jul 7, 2023
d6681c3
Added calens file
JuancaG05 Jul 7, 2023
512f1c5
Calens changelog updated
JuancaG05 Jul 7, 2023
91622dd
Added margin in image item to see the imagen bigger like was before t…
Aitorbp Jul 3, 2023
5ed845f
Optimizing code
Aitorbp Jul 3, 2023
781beeb
Added calens file
Aitorbp Jul 4, 2023
d0638c9
Calens changelog updated
Aitorbp Jul 4, 2023
d53fb78
add tablayout for markdown file
parneet-guraya Jun 24, 2023
7d9c8b3
add viewpager with tablayout
parneet-guraya Jun 30, 2023
3b78d1c
add requested changes
parneet-guraya Jul 4, 2023
c8864d2
add top & bottom padding
parneet-guraya Jul 10, 2023
4dae1b4
First attempt to introduce coil to fetch thumbnails
abelgardep Mar 23, 2023
f07d5f7
- Solving import errors
manuelplazaspalacio Jun 21, 2023
02c4783
- Adding placeholders.
manuelplazaspalacio Jun 21, 2023
dd8af95
- Changing spaces placeholder image.
manuelplazaspalacio Jun 22, 2023
54563e8
- Moving coil lib declaration.
manuelplazaspalacio Jun 22, 2023
f93767a
- Solving bug coil lib declaration.
manuelplazaspalacio Jun 22, 2023
5e5e60d
Calens changelog updated
manuelplazaspalacio Jun 22, 2023
db035f4
Thumnails not loaded PR changed.
manuelplazaspalacio Jun 26, 2023
4e54321
Center crop file list images
manuelplazaspalacio Jul 11, 2023
90d0721
Solved bug not changing image when updating image in other client.
manuelplazaspalacio Jul 12, 2023
6c12830
Calens changelog updated
manuelplazaspalacio Jul 12, 2023
1eb0a4a
[tx] updated from transifex
ownclouders Jul 13, 2023
b6f9c17
[tx] updated from transifex
ownclouders Jul 18, 2023
a5c1f30
Bump androidxFragment from 1.5.5 to 1.5.7
dependabot[bot] May 5, 2023
43a61b6
Update library reference
JuancaG05 Jul 19, 2023
aee3065
Bump moshi from 1.14.0 to 1.15.0
dependabot[bot] Jul 12, 2023
33d0bdc
[tx] updated from transifex
ownclouders Jul 21, 2023
98930f9
Calens changelog updated
JuancaG05 Jun 14, 2023
e748a4b
Added 3-dot icon button to every file row in file list
manuelplazaspalacio Jul 13, 2023
2858900
Move share icons to the subtitle line of the file
manuelplazaspalacio Jul 13, 2023
dbc4a81
Remove shared folder thumbnail
manuelplazaspalacio Jul 13, 2023
0d91145
First draft of bottom sheet with file options
manuelplazaspalacio Jul 13, 2023
a00107e
Calens changelog updated
JuancaG05 Jun 22, 2023
e91204c
Updated library reference
JuancaG05 Jun 22, 2023
e46c9de
Added header to bottom sheet
JuancaG05 Jun 30, 2023
509b13b
Added icons and suitable titles for menu options in bottom sheet
JuancaG05 Jul 4, 2023
8e95bda
Reordering some file menu options in the bottom sheet
JuancaG05 Jul 5, 2023
c1a266a
Added onClick listeners to menu options in bottom sheet
JuancaG05 Jul 6, 2023
22a0c55
Added calens file
JuancaG05 Jul 6, 2023
b7d80f7
Calens changelog updated
JuancaG05 Jul 6, 2023
954c147
Reordering options bottom dialog.
manuelplazaspalacio Jul 13, 2023
0b4902e
Reordered some top bar 3-dot menu options
JuancaG05 Jul 21, 2023
0c0f238
Calens changelog updated
JuancaG05 Jul 21, 2023
d42e46e
[tx] updated from transifex
ownclouders Jul 27, 2023
fb1471a
Added new test for OCSharedPreferenceProvider
Aitorbp Jul 4, 2023
d24c824
Added new test for ScopedStorageProviderTest
Aitorbp Jul 6, 2023
30eecfc
Added new test for ScopedStorageProviderTest
Aitorbp Jul 6, 2023
32bbf53
Updated changelog
Aitorbp Jul 7, 2023
d60b602
Calens changelog updated
Aitorbp Jul 7, 2023
377c2aa
Some fixes from bitrise
Aitorbp Jul 14, 2023
8fec7ce
Some fixes in test
Aitorbp Jul 17, 2023
51ea8fa
Added changes in call review
Aitorbp Jul 19, 2023
80f3f89
Added two new tests
Aitorbp Jul 19, 2023
7a2ae2c
Calens changelog updated
Aitorbp Jul 19, 2023
5071d71
Added changes from code review
Aitorbp Jul 19, 2023
7d2a585
Changed name of the tests
Aitorbp Jul 20, 2023
5ac7c4c
Moved SharedPreferencesProvider, LocalStorageProvider and ScopedStora…
Aitorbp Jul 20, 2023
1181654
Some fix from bitrise
Aitorbp Jul 20, 2023
2c25a74
Changed order package
Aitorbp Jul 21, 2023
1f14105
Changed order package
Aitorbp Jul 21, 2023
b141704
Fix bitrise
Aitorbp Jul 21, 2023
a2e6dc7
Fix bitrise
Aitorbp Jul 21, 2023
dc3c2fa
Calens changelog updated
Aitorbp Jul 19, 2023
f5fd83a
Calens changelog updated
Aitorbp Jul 27, 2023
78a7da2
Added languages to locales_config.xml
Aitorbp Jul 13, 2023
7456cd4
Added calens to issue
Aitorbp Jul 13, 2023
c2c14b7
Calens changelog updated
Aitorbp Jul 13, 2023
ba9e5ee
Some specific changed from code review
Aitorbp Jul 20, 2023
ce7cba2
Changed from code review
Aitorbp Jul 21, 2023
9ed7405
Update library
Aitorbp Jul 27, 2023
0ecd803
Removed automatic redirection to browser when there is a fixed server…
JuancaG05 Jul 20, 2023
b8f2ab7
Calens file added
JuancaG05 Jul 20, 2023
cf33af2
Fix UI test
JuancaG05 Jul 24, 2023
4c51191
Calens changelog updated
JuancaG05 Jul 24, 2023
af08621
Calens changelog updated
Aitorbp Jul 27, 2023
6f6a681
Deleted verification method getServerInfo
Aitorbp Jul 28, 2023
28bee36
[tx] updated from transifex
ownclouders Jul 29, 2023
83fcb7a
Added to createdFolderDialog logic for forbidden characters
Aitorbp Jul 11, 2023
36efbcc
Added calens
Aitorbp Jul 11, 2023
3bf29b5
Calens changelog updated
Aitorbp Jul 11, 2023
77f5e0c
CHanged string filename_forbidden_characters
Aitorbp Jul 12, 2023
385680c
Some fixes from bitrise
Aitorbp Jul 14, 2023
fed2f6f
Added changes code review and functionality input
Aitorbp Jul 19, 2023
fb68b08
Calens changelog updated
Aitorbp Jul 19, 2023
13435ef
Some specific changed form code review
Aitorbp Jul 20, 2023
c0c17f4
Calens changelog updated
Aitorbp Jul 27, 2023
2086af9
Added functionality to rename file dialog
Aitorbp Jul 28, 2023
7099a47
Bitrise fix
Aitorbp Jul 28, 2023
3c705df
Changed literal in ReceiveExternalFilesActivity
Aitorbp Jul 28, 2023
63d113d
[tx] updated from transifex
ownclouders Aug 1, 2023
191287f
Adding branding option to prevent http traffic.
manuelplazaspalacio Jul 26, 2023
00776f6
Testing the http enforced.
manuelplazaspalacio Jul 26, 2023
b6d1383
Solving klint bugs.
manuelplazaspalacio Jul 26, 2023
67f1acf
Added calens file.
manuelplazaspalacio Jul 26, 2023
fbc3b83
Calens changelog updated
manuelplazaspalacio Jul 26, 2023
656e4cb
Calens changelog updated
manuelplazaspalacio Jul 31, 2023
8964457
Calens changelog updated
manuelplazaspalacio Aug 1, 2023
0c0cf4e
Added new share icon to align with other platform
Aitorbp Jul 18, 2023
1cdb309
Added new share icon in more screens
Aitorbp Jul 27, 2023
520ed74
git commit added calens to align_share_icons_with_other_platforms
Aitorbp Jul 28, 2023
94e0909
Calens changelog updated
Aitorbp Jul 28, 2023
c0a92f3
On small fix in calens
Aitorbp Jul 28, 2023
6f82981
Calens changelog updated
Aitorbp Jul 28, 2023
e003a0e
QA review fixes
Aitorbp Aug 1, 2023
d9035bb
[tx] updated from transifex
ownclouders Aug 3, 2023
6a8a9eb
Resolved conflict with master
Aitorbp Aug 1, 2023
f2330de
Code review fixes
Aitorbp Aug 1, 2023
59d33b4
Calens changelog updated
Aitorbp Aug 1, 2023
bbd8474
Created new design for detail file
Aitorbp Jul 12, 2023
a6a526a
Added calens
Aitorbp Jul 12, 2023
1ade6a3
Resolved conflict with master
Aitorbp Aug 1, 2023
b4eae7c
Added last sync logic
Aitorbp Jul 12, 2023
9c34d55
Some fixes from bitrise
Aitorbp Jul 14, 2023
d4152f3
Some fixes in thumbnail and changed name path
Aitorbp Jul 17, 2023
2b3bc12
Added new detail design screen and GetFileWithSyncInfoByIdUseCase
Aitorbp Jul 24, 2023
cbbdfc7
Calens changelog updated
Aitorbp Jul 24, 2023
684f168
Done unit test GetFileWithSyncInfoByIdUseCaseTest
Aitorbp Jul 27, 2023
ebbeaa3
Done unit test GetFileWithSyncInfoByIdUseCaseTest
Aitorbp Jul 27, 2023
38ac81b
Done unit test OCFileRepositoryTest
Aitorbp Jul 27, 2023
a3a7b0d
Done ui test FileDetailsFragmentTest
Aitorbp Jul 27, 2023
167399f
some changes in file detail fragment
Aitorbp Jul 27, 2023
883c039
Added new example models for testing
Aitorbp Jul 27, 2023
f71a652
Implement ContainerActivity in TestShareFileActivity
Aitorbp Jul 27, 2023
6947cb2
One fix bitrise
Aitorbp Jul 27, 2023
35efe7b
more fixes bitrise
Aitorbp Jul 27, 2023
1f80c6b
more fixes bitrise
Aitorbp Jul 27, 2023
fb47c80
Code review fixes
Aitorbp Aug 1, 2023
d6a11d4
Calens changelog updated
Aitorbp Aug 1, 2023
0002225
Changes from QA
Aitorbp Aug 2, 2023
a2c64f6
Changes from bitrise in tests
Aitorbp Aug 2, 2023
5eac954
Checking if device is secure.
manuelplazaspalacio Jul 5, 2023
dc0bb1b
Solving error when checking device protection.
manuelplazaspalacio Jul 7, 2023
708d2b5
Changing comments
manuelplazaspalacio Jul 7, 2023
a410e17
Changing test namings
manuelplazaspalacio Jul 10, 2023
746eaf4
Calens changelog updated
manuelplazaspalacio Aug 1, 2023
7474e36
Changed logic to show security and modify passcode settings.
manuelplazaspalacio Aug 2, 2023
3db1946
Modifying test with the new logic.
manuelplazaspalacio Aug 2, 2023
c11d8f6
Showing selected enforced security when device_protection to true.
manuelplazaspalacio Aug 3, 2023
b0e1cad
[tx] updated from transifex
ownclouders Aug 4, 2023
0702ceb
[tx] updated from transifex
ownclouders Aug 5, 2023
8dd5fc6
modifications in release template, some steps changed order
jesmrec Aug 4, 2023
c4b472f
[tx] updated from transifex
ownclouders Aug 8, 2023
efd08c3
Updating version in gradle to 4.1.0-beta.1
manuelplazaspalacio Aug 7, 2023
8400a7b
Added old release notes
manuelplazaspalacio Aug 7, 2023
c7c0512
Putting the correct versionCode for the beta version.
manuelplazaspalacio Aug 7, 2023
386e355
[tx] updated from transifex
ownclouders Aug 9, 2023
6fdbea9
[tx] updated from transifex
ownclouders Aug 10, 2023
33c0ba8
fix typo in lenght overflow error message
jesmrec Aug 10, 2023
ae53c0b
[tx] updated from transifex
ownclouders Aug 11, 2023
162f609
[tx] updated from transifex
ownclouders Aug 12, 2023
c99ef57
[tx] updated from transifex
ownclouders Aug 15, 2023
052a15e
Changed some code from onCreate to onStart
Aitorbp Aug 8, 2023
21da37c
added calens
Aitorbp Aug 10, 2023
cae81da
Calens changelog updated
Aitorbp Aug 11, 2023
606d2d2
Update Android SBOM as part of the release process
michaelstingl Aug 15, 2023
40b4d86
Added unit test for AppRegistry data source
Aitorbp Aug 2, 2023
b87ba60
Working with outh tests
Aitorbp Aug 3, 2023
4448d92
Working with loginOAuth tests
Aitorbp Aug 4, 2023
ce0a84d
Improved test CapabilitiesDataSource and one deletion
Aitorbp Aug 7, 2023
d0a897f
Fixes from CR
Aitorbp Aug 10, 2023
c0ef297
Some fixes from cr and bitrise
Aitorbp Aug 14, 2023
06c1490
Fixes from bitrise
Aitorbp Aug 14, 2023
39901d9
Fixes from bitrise
Aitorbp Aug 14, 2023
cfd80ba
Changes require from master
Aitorbp Aug 17, 2023
1eba0a7
Working with LocalFileDataSourceTest
Aitorbp Aug 8, 2023
2ec1909
Tests done
Aitorbp Aug 10, 2023
e3deb39
Calens added
Aitorbp Aug 10, 2023
22a2e6a
Calens changelog updated
Aitorbp Aug 10, 2023
1c8041d
Some fixes from cr
Aitorbp Aug 14, 2023
934a440
Changes in Snack-bar
Aitorbp Aug 16, 2023
4b29593
Calens added
Aitorbp Aug 16, 2023
1599252
Calens changelog updated
Aitorbp Aug 16, 2023
a811153
Bitrise fix
Aitorbp Aug 16, 2023
265c0b7
Bump androidx.core:core-ktx from 1.9.0 to 1.10.1
dependabot[bot] Aug 8, 2023
d3f6672
changed 2 by 1
Aitorbp Aug 17, 2023
28690c3
Added calens
Aitorbp Aug 17, 2023
fc7e12f
Calens changelog updated
Aitorbp Aug 17, 2023
390c65a
Changed how to get the variable of fileIcon
Aitorbp Aug 16, 2023
0068306
Some fixes from cr
Aitorbp Aug 17, 2023
de63971
Returned to previous version
Aitorbp Aug 18, 2023
11f38e7
Calens added
Aitorbp Aug 18, 2023
e384eaf
Calens changelog updated
Aitorbp Aug 21, 2023
7ffdddc
Removing extra path on check path existence.
manuelplazaspalacio Aug 18, 2023
4846df7
Adding calens changelog.
manuelplazaspalacio Aug 18, 2023
cb56feb
Calens changelog updated
manuelplazaspalacio Aug 18, 2023
1a7bf28
Solving bug when copyin or moving
manuelplazaspalacio Aug 22, 2023
a69e756
Solving CR errors
manuelplazaspalacio Aug 23, 2023
40d7be2
Calens changelog updated
manuelplazaspalacio Aug 23, 2023
fe96225
Solving Test bugs
manuelplazaspalacio Aug 23, 2023
047cef4
Added releaseNotes, moved changelog and changed version number
Aitorbp Aug 23, 2023
d8a0d41
Calens changelog updated
Aitorbp Aug 23, 2023
1c4ecbe
Added screenshots to docs_resources
Aitorbp Aug 23, 2023
92b23dd
Changed share icon in logging settings
Aitorbp Aug 23, 2023
58f919a
Changed literal when is not possible to copy a folder into a descendant
Aitorbp Aug 23, 2023
8586204
Solving bug showing connection not secure when enforce secure connect…
manuelplazaspalacio Aug 24, 2023
34ac95c
Coil library is not used with fileIcons
Aitorbp Aug 24, 2023
9f68ac1
Solving bugs when getting file existence.
manuelplazaspalacio Aug 24, 2023
ece91eb
Solving bugs when getting file existence in OC10
manuelplazaspalacio Aug 24, 2023
6b22ce4
Fix in snackbar when copy without server on
Aitorbp Aug 29, 2023
daeea3e
New fix for snackbar when copy without server on
Aitorbp Aug 30, 2023
37eec7b
Fix for snackbar when copy without server on, updating library reference
manuelplazaspalacio Aug 30, 2023
a365dc1
Added constant for the http not allowed exception message.
manuelplazaspalacio Aug 31, 2023
71a0762
Added parameters names
Aitorbp Aug 31, 2023
52e86db
Replace runBlocking with runTest for testing
abelgardep Aug 20, 2023
f9265be
Changed hardcoded alue in ReleaseNotesActivityTest
Aitorbp Sep 5, 2023
cbbba28
Added list mocked
Aitorbp Sep 5, 2023
260b13a
Added new dialog to check all conflict inside
Aitorbp Aug 22, 2023
dd31bca
One fix
Aitorbp Aug 22, 2023
a2dedec
Fixes from CR
Aitorbp Aug 25, 2023
da3ae3a
Fixes when the screen is rotated
Aitorbp Sep 5, 2023
7431cb0
Fix cr 2
Aitorbp Sep 6, 2023
7c6e12d
Fix cr 3
Aitorbp Sep 7, 2023
de89cb8
Added folder unreleased and calens
Aitorbp Sep 13, 2023
bdf1fd8
Calens changelog updated
Aitorbp Sep 13, 2023
2f70188
Fixes from bitrise
Aitorbp Sep 13, 2023
aa431e8
Bump actions/checkout from 3 to 4
dependabot[bot] Sep 13, 2023
492883e
[tx] updated from transifex
ownclouders Sep 15, 2023
3ee918b
[tx] updated from transifex
ownclouders Sep 16, 2023
4c2036e
new improvements in release checklist
jesmrec Aug 30, 2023
8bc37ed
Added taskAffinity to application manifest.
manuelplazaspalacio Sep 20, 2023
97f52cd
add new entry to release notes: http traffic banned
jesmrec Sep 20, 2023
dbbe403
Avoiding crashes when it's null
Aitorbp Sep 25, 2023
b2f94fd
Added calens
Aitorbp Sep 27, 2023
7834b11
Calens changelog updated
Aitorbp Sep 27, 2023
91cfb0c
Fix cr
Aitorbp Sep 28, 2023
df21ecd
Calens changelog updated
Aitorbp Sep 28, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Modifying test with the new logic.
  • Loading branch information
manuelplazaspalacio authored and jesmrec committed Sep 5, 2023
commit 3db1946551c7cdcaf2bf88da44a750e536a7bbe6
Original file line number Diff line number Diff line change
@@ -149,7 +149,7 @@ class SettingsSecurityViewModelTest : ViewModelTest() {
every { mdmProvider.getBrandingInteger(any(), R.integer.lock_enforced) } returns LockEnforcedType.EITHER_ENFORCED.ordinal

val result = securityViewModel.isSecurityEnforcedEnabled()
assertFalse(result)
assertTrue(result)

}

@@ -160,7 +160,7 @@ class SettingsSecurityViewModelTest : ViewModelTest() {
every { mdmProvider.getBrandingInteger(any(), R.integer.lock_enforced) } returns LockEnforcedType.DISABLED.ordinal

val result = securityViewModel.isSecurityEnforcedEnabled()
assertFalse(result)
assertTrue(result)
}

@Test