language review

[EParzefall]

Fixed various formal and some language issues I noticed while translating.

[CLAassistant]

All committers have signed the CLA.

[phil-davis]

LGTM

[jesmrec]

Thanks a lot for reviewing!

We'll check it.

[JuancaG05]

Hey @EParzefall thanks a lot for this review! I was taking a look and I left some comments 😃.
BTW, do you know if strings that are updated here are uploaded to transifex as new strings so that community can translate them again?

[EParzefall]

Hey @EParzefall thanks a lot for this review! I was taking a look and I left some comments 😃. BTW, do you know if strings that are updated here are uploaded to transifex as new strings so that community can translate them again?

I only heard/read that there is a daily sync with Transifex. I expected you know how it works.

[JuancaG05]

I only heard/read that there is a daily sync with Transifex. I expected you know how it works.

I think these modified strings are uploaded as well, it was just to make sure. And no, Transifex is not our responsibility, it's just a service that our product uses, so our team doesn't need to know deeply how it works.

[phil-davis]

The flow is that this PR first needs to be merged. Then a nightly job will add/adjust the source strings that need to be translated in Transifex.
Then as people add translations of the strings, a nightly Transifex job will push them back to this repo.

[jesmrec]

The flow is that this PR first needs to be merged. Then a nightly job will add/adjust the source strings that need to be translated in Transifex.
Then as people add translations of the strings, a nightly Transifex job will push them back to this repo.

In case an existing string is re-translated (because an error, a bad translation or whatever...), is the previous translation cleaned up in tfx?

[JuancaG05]

Hi @phil-davis, thanks for the explanation! 😃 I was aware of the basic flow you describe, I know that happens for newly added strings. It's just that I wasn't sure if that flow is triggered as well for already existent strings which are modified in the default language resource file, as it happens in this PR.

[phil-davis]

In case an existing string is re-translated (because an error, a bad translation or whatever...), is the previous translation cleaned up in tfx?

yes, AFAIK. And it is a bit annoying, IMO, for translators when a string only changes a tiny bit. It would be nice if Transifex would show the previous string and previous translation, and give the translator the option to use the previous translation (adjusting it a tiny bit)

So this sort of language review of strings that get translated makes a lot of "noise" for translators.

[EParzefall]

In case an existing string is re-translated (because an error, a bad translation or whatever...), is the previous translation cleaned up in tfx?

yes, AFAIK. And it is a bit annoying, IMO, for translators when a string only changes a tiny bit. It would be nice if Transifex would show the previous string and previous translation, and give the translator the option to use the previous translation (adjusting it a tiny bit)

So this sort of language review of strings that get translated makes a lot of "noise" for translators.

Actually at least the translation memory in Transifex should show the previous translation with an percentage how well it matches. In many cases 99%- That's why I dared to add all the missing periods after complete sentences. One click. But yes, this cleaning up will be a nuisance for translators.