Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharing Log Files seamlessly within the ownCloud Android App #4215

Merged
merged 5 commits into from
Nov 24, 2023
Merged

Sharing Log Files seamlessly within the ownCloud Android App #4215

merged 5 commits into from
Nov 24, 2023

Conversation

Aitorbp
Copy link
Contributor

@Aitorbp Aitorbp commented Nov 16, 2023 •
edited
Loading

Related Issues

App:#4156

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

@Aitorbp Aitorbp requested a review from JuancaG05 November 16, 2023 12:17
@Aitorbp Aitorbp self-assigned this Nov 16, 2023
@Aitorbp Aitorbp linked an issue Nov 16, 2023 that may be closed by this pull request
Sharing Log Files seamlessly within the ownCloud Android App #4156
Closed
@Aitorbp Aitorbp force-pushed the feature/sharing_log_files_seamlessly_within_owncloud_app branch 3 times, most recently from 8af3873 to 8fbda7d Compare November 17, 2023 07:38
JuancaG05
JuancaG05 requested changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes requested here @Aitorbp

changelog/unreleased/4215 Outdated Show resolved Hide resolved
owncloudApp/src/main/java/com/owncloud/android/extensions/ActivityExt.kt Outdated Show resolved Hide resolved
@Aitorbp Aitorbp force-pushed the feature/sharing_log_files_seamlessly_within_owncloud_app branch 4 times, most recently from 58d0904 to 888d239 Compare November 21, 2023 17:46
@Aitorbp Aitorbp requested a review from JuancaG05 November 22, 2023 07:41
@Aitorbp Aitorbp force-pushed the feature/sharing_log_files_seamlessly_within_owncloud_app branch from f1b31f8 to 6113cba Compare November 22, 2023 07:48
JuancaG05
JuancaG05 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesmrec
Copy link
Collaborator

jesmrec commented Nov 22, 2023

Feature works fine, ownCloud is now an option to share logs.

But i noticed that the shared log file uses .bin extension. Maybe not related with this but it deserves a look.

@Aitorbp
Copy link
Contributor Author

Aitorbp commented Nov 24, 2023

There are internal android studio method that do not recognize .log extensions, specifically this one: MimeTypeMap.getSingleton().getMimeTypeFromExtension(displayName.substring(index + 1)). Since it does not recognize it, it tries to create a new extension, therefore it puts the .bin in front of the .log.

The .log extension is recognized as a mimeType application/octet-stream, which is a generic MIME type indicating that the contents of the file are binary and not specified more specifically.

The solution that has been carried out in this issue is to put a condition when it is a .log file so that it does not add the .bin extension.

@jesmrec
Copy link
Collaborator

jesmrec commented Nov 24, 2023

Fixed and approved

@Aitorbp Aitorbp force-pushed the feature/sharing_log_files_seamlessly_within_owncloud_app branch from a4f7d07 to 7341fb0 Compare November 24, 2023 12:29
@jesmrec jesmrec force-pushed the feature/sharing_log_files_seamlessly_within_owncloud_app branch from 63f38ed to 7341fb0 Compare November 24, 2023 13:35
@Aitorbp Aitorbp merged commit 5398901 into master Nov 24, 2023
7 checks passed
@Aitorbp Aitorbp deleted the feature/sharing_log_files_seamlessly_within_owncloud_app branch November 24, 2023 20:14
Aitorbp added a commit that referenced this pull request Feb 5, 2024
@Aitorbp
Merge pull request #4215 from owncloud/feature/sharing_log_files_seam…
9a51608 
…lessly_within_owncloud_app

Sharing Log Files seamlessly within the ownCloud Android App
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuancaG05 JuancaG05 JuancaG05 approved these changes

Assignees

@Aitorbp Aitorbp

Labels
Approved by qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sharing Log Files seamlessly within the ownCloud Android App
3 participants
@Aitorbp @jesmrec @JuancaG05