Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECHNICAL] Unit tests for repository classes - Part 2 #4389

Merged
merged 8 commits into from
Nov 22, 2024

Conversation

JuancaG05
Copy link
Collaborator

@JuancaG05 JuancaG05 commented Apr 18, 2024

Related Issues

App: #4233

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@JuancaG05 JuancaG05 self-assigned this Apr 18, 2024
@JuancaG05 JuancaG05 linked an issue Sep 6, 2024 that may be closed by this pull request
6 tasks
@JuancaG05 JuancaG05 force-pushed the technical/testing_repositories_2 branch from 9d65650 to e9a432e Compare October 1, 2024 14:55
@JuancaG05 JuancaG05 force-pushed the technical/testing_repositories_2 branch from 40b7649 to 080fc49 Compare October 25, 2024 09:06
@JuancaG05 JuancaG05 marked this pull request as ready for review October 25, 2024 09:08
@JuancaG05 JuancaG05 requested a review from joragua October 25, 2024 09:08
@JuancaG05 JuancaG05 force-pushed the technical/testing_repositories_2 branch from 34e55fb to 2df281e Compare October 25, 2024 09:12
Copy link
Collaborator

@joragua joragua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment here! 😄 @JuancaG05

Copy link
Collaborator

@joragua joragua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Copy link
Contributor

@jabarros jabarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a huge and awesome work, @JuancaG05 !!

@JuancaG05 JuancaG05 force-pushed the technical/testing_repositories_2 branch from d74fc51 to 0ee46d4 Compare November 21, 2024 07:50
@JuancaG05 JuancaG05 requested a review from jabarros November 21, 2024 09:27
@JuancaG05 JuancaG05 force-pushed the technical/testing_repositories_2 branch from d999ebd to ef54ad9 Compare November 22, 2024 13:45
@JuancaG05 JuancaG05 merged commit dfb744f into master Nov 22, 2024
7 checks passed
@JuancaG05 JuancaG05 deleted the technical/testing_repositories_2 branch November 22, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TECHNICAL] Unit tests for repository classes - Part 2
3 participants