Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Some colors are not correctly set up #4463

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

Aitorbp
Copy link
Contributor

@Aitorbp Aitorbp commented Sep 5, 2024

Related Issues

App: #4442

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@Aitorbp Aitorbp self-assigned this Sep 5, 2024
@Aitorbp Aitorbp linked an issue Sep 5, 2024 that may be closed by this pull request
@Aitorbp
Copy link
Contributor Author

Aitorbp commented Sep 5, 2024

To choose the status bar color we had two options:

Option 1: Change the colorPrimaryDark. This approach is the most generic and involves just one change to the app, as this change is only necessary to make it visible throughout the app. According to Android documentation this is the functionality of the attribute: A darker variant of the primary color, used for the status bar (on Android 5.0+) and contextual app bars.

Option 2: Change the color of statusBarColor, this would involve making the change in each Activity of the app, being a more particular approach. This attribute sets the color for the status bar (and only that). If you want to change the color of the Status Bar programmatically this could be the best option.

We are going to go with the first option, as it only involves the app bars and we don't need to add programmatically code in each Activity.

@Aitorbp Aitorbp requested a review from JuancaG05 September 6, 2024 08:29
@Aitorbp Aitorbp force-pushed the feature/some_colors_are_not_correctly_set_up branch from 326d427 to 31ba7dd Compare September 6, 2024 11:09
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're not using colorPrimaryDark for other purposes, let's go with this approach for the moment

@jesmrec
Copy link
Collaborator

jesmrec commented Sep 10, 2024

Test done here:

in file setup.xml, the field actionbar_start_color points to @color/primary

I changed the value of @color/primary to other values to check that the manage accounts dialog bar, and the notifications bar are tinted with such color.

It worked fine.

You can move it forward.

@Aitorbp Aitorbp merged commit 9e6e168 into master Sep 10, 2024
7 checks passed
@Aitorbp Aitorbp deleted the feature/some_colors_are_not_correctly_set_up branch September 10, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Some colors are not correctly set up
3 participants