[FEATURE REQUEST] Add status message when (un)setting av. offline from preview #4482

joragua · 2024-10-01T11:03:12Z

Related Issues

App: #4382

Add changelog files for the fixed issues in folder changelog/unreleased. More info here
Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

Checks done: #4482 (comment)

Reports:

(1) Snackbar not correctly displayed in image preview [FEATURE REQUEST] Add status message when (un)setting av. offline from preview #4482 (comment)

CLAassistant · 2024-10-01T11:03:17Z

All committers have signed the CLA.

JuancaG05

Good job @joragua! Some comments and questions here 👍

owncloudApp/src/main/java/com/owncloud/android/presentation/previews/PreviewTextViewModel.kt

owncloudApp/src/main/java/com/owncloud/android/ui/preview/PreviewImageViewModel.kt

owncloudApp/src/main/java/com/owncloud/android/ui/preview/PreviewAudioFragment.kt

owncloudApp/src/main/java/com/owncloud/android/ui/preview/PreviewImageFragment.kt

owncloudApp/src/main/java/com/owncloud/android/ui/preview/PreviewVideoActivity.kt

JuancaG05

Some more comments and changes here @joragua 🧑🏻‍💻

owncloudApp/src/main/java/com/owncloud/android/presentation/previews/PreviewAudioViewModel.kt

owncloudApp/src/main/java/com/owncloud/android/presentation/previews/PreviewVideoViewModel.kt

owncloudApp/src/main/java/com/owncloud/android/ui/preview/PreviewImageViewModel.kt

owncloudApp/src/main/java/com/owncloud/android/ui/preview/PreviewAudioFragment.kt

owncloudApp/src/main/res/values/strings.xml

owncloudApp/src/main/java/com/owncloud/android/ui/preview/PreviewAudioFragment.kt

owncloudApp/src/main/java/com/owncloud/android/ui/preview/PreviewVideoActivity.kt

JuancaG05 · 2024-10-08T06:48:28Z

There are several KtLint reports as well in the BitRise workflow, take a look at them and fix them. You can rebase this branch against master as well @joragua 👍

JuancaG05

One more tiny change and we're done @joragua!

owncloudApp/src/main/java/com/owncloud/android/ui/preview/PreviewAudioFragment.kt

JuancaG05

LGTM now! Good job @joragua 🏅

jesmrec · 2024-10-09T08:21:40Z

Checks done:

Set as av. offline (both orientations)

Image preview
Text preview
Audio preview
Video preview

Unset as av. offline (both orientations)

Image preview
Text preview
Audio preview
Video preview

Image, text and audio are always downloaded whwn previewed. Videos can be streamed, but during the streaming, the av. offline options are not available, that means, no extra case there.

jesmrec · 2024-10-09T08:59:46Z

(1) [FIXED]

just a tiny detail i noticed: in the image previews, the snackbar is smaller (in height) than in other previews. I guess that is something related with system, but it took my attention. I tested with two different devices. Check the difference with the following short videos:

txt preview	image preview
https://github.com/user-attachments/assets/f25a79da-783d-4ad1-9fbb-d580cd838934	https://github.com/user-attachments/assets/9407ce38-ce91-49fc-bb43-1e82cb993bdf

i suggest to download both of them and play together to compare.

Pixel 2, Android 11
Xiaomi Redmi 13, Android 14
cdbc8705

jesmrec · 2024-10-09T09:09:17Z

Related with (1), by setting as av. offline in landscape orientation (image preview):

Screen_recording_20241009_110643.mp4

The snackbar does not rise from the bottom (maybe because the margin)
The android bar, placed to the left, overlaps part of the message

could this be part of the same issue?

joragua · 2024-10-09T12:39:51Z

(1) I think it's fixed. requireActivity().window.decorView was the solution, because the activity manages the view of image previews and not the fragment.

Take a look if you can 😀

JuancaG05

LGTM 👍

jesmrec · 2024-10-10T08:16:46Z

(1) fixed

jesmrec · 2024-10-10T08:18:42Z

Approved on my side.

There are some conflicts in the branch because the changelog items, could you take a look before merging @joragua ?

… preview

joragua linked an issue Oct 1, 2024 that may be closed by this pull request

[FEATURE REQUEST] Add status message when (un)setting av. offline from preview #4382

Closed

16 tasks

joragua force-pushed the feature/add_feedback_in_preview_menu branch 2 times, most recently from 554ca38 to e892103 Compare October 1, 2024 11:08

joragua self-assigned this Oct 2, 2024

joragua force-pushed the feature/add_feedback_in_preview_menu branch 3 times, most recently from ac8ab37 to 3deecbd Compare October 2, 2024 12:35

joragua changed the title ~~[FEATURE] Add status message when (un)setting av. offline from preview~~ [FEATURE REQUEST] Add status message when (un)setting av. offline from preview Oct 2, 2024

joragua force-pushed the feature/add_feedback_in_preview_menu branch from 091c1a4 to 8eaa4e9 Compare October 3, 2024 12:03

joragua requested a review from JuancaG05 October 3, 2024 12:26

JuancaG05 requested changes Oct 7, 2024

View reviewed changes

joragua force-pushed the feature/add_feedback_in_preview_menu branch from 2e420fc to ca5c106 Compare October 8, 2024 06:23

joragua requested a review from JuancaG05 October 8, 2024 06:24

JuancaG05 requested changes Oct 8, 2024

View reviewed changes

joragua force-pushed the feature/add_feedback_in_preview_menu branch 2 times, most recently from 3a61024 to b93b787 Compare October 8, 2024 09:19

joragua requested a review from JuancaG05 October 8, 2024 09:58

JuancaG05 requested changes Oct 9, 2024

View reviewed changes

owncloudApp/src/main/java/com/owncloud/android/ui/preview/PreviewAudioFragment.kt Outdated Show resolved Hide resolved

joragua force-pushed the feature/add_feedback_in_preview_menu branch from cdbc870 to 22aed52 Compare October 9, 2024 07:26

joragua requested a review from JuancaG05 October 9, 2024 07:35

JuancaG05 approved these changes Oct 9, 2024

View reviewed changes

joragua force-pushed the feature/add_feedback_in_preview_menu branch from d7545ab to fa39250 Compare October 9, 2024 12:30

joragua requested a review from JuancaG05 October 9, 2024 12:40

JuancaG05 approved these changes Oct 10, 2024

View reviewed changes

jesmrec added the Approved by qa label Oct 10, 2024

joragua added 14 commits October 10, 2024 10:23

feat: added snackbar when (un)setting av.offline

1d23100

feat: updated options menu in text preview

d39be71

feat: added snackbar when (un)setting av.offline from video and audio…

6f7233c

… preview

refactor: some changes in prepareOptionsMenu structure in text preview

08f09a5

feat: updated options menu in audio and video preview

8358833

refactor: some changes in view model of text preview

a9d2177

feat: updated options menu in image preview

c2c86ba

refactor: changes in image preview snackbar

e7b3854

chore: added calens file

61632b9

feat: added release note

227e484

refactor: some ktlint changes

f06b6b2

refactor: some CR changes

585df15

refactor: removed an additional identation

683e933

fix: modified snackbar in image preview avoiding margins

97dbbbf

joragua force-pushed the feature/add_feedback_in_preview_menu branch 2 times, most recently from 2c40fcc to 97dbbbf Compare October 10, 2024 08:56

docs: calens changelog updated

bdd665f

joragua merged commit 51c910a into master Oct 10, 2024
3 checks passed

joragua deleted the feature/add_feedback_in_preview_menu branch October 10, 2024 09:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FEATURE REQUEST] Add status message when (un)setting av. offline from preview #4482

[FEATURE REQUEST] Add status message when (un)setting av. offline from preview #4482

joragua commented Oct 1, 2024 •

edited by jesmrec

Loading

CLAassistant commented Oct 1, 2024 •

edited

Loading

JuancaG05 left a comment

JuancaG05 left a comment

JuancaG05 commented Oct 8, 2024

JuancaG05 left a comment

JuancaG05 left a comment

jesmrec commented Oct 9, 2024 •

edited

Loading

jesmrec commented Oct 9, 2024 •

edited

Loading

jesmrec commented Oct 9, 2024

joragua commented Oct 9, 2024 •

edited

Loading

JuancaG05 left a comment

jesmrec commented Oct 10, 2024

jesmrec commented Oct 10, 2024

[FEATURE REQUEST] Add status message when (un)setting av. offline from preview #4482

[FEATURE REQUEST] Add status message when (un)setting av. offline from preview #4482

Conversation

joragua commented Oct 1, 2024 • edited by jesmrec Loading

Related Issues

QA

CLAassistant commented Oct 1, 2024 • edited Loading

JuancaG05 left a comment

Choose a reason for hiding this comment

JuancaG05 left a comment

Choose a reason for hiding this comment

JuancaG05 commented Oct 8, 2024

JuancaG05 left a comment

Choose a reason for hiding this comment

JuancaG05 left a comment

Choose a reason for hiding this comment

jesmrec commented Oct 9, 2024 • edited Loading

jesmrec commented Oct 9, 2024 • edited Loading

(1) [FIXED]

jesmrec commented Oct 9, 2024

joragua commented Oct 9, 2024 • edited Loading

JuancaG05 left a comment

Choose a reason for hiding this comment

jesmrec commented Oct 10, 2024

jesmrec commented Oct 10, 2024

joragua commented Oct 1, 2024 •

edited by jesmrec

Loading

CLAassistant commented Oct 1, 2024 •

edited

Loading

jesmrec commented Oct 9, 2024 •

edited

Loading

jesmrec commented Oct 9, 2024 •

edited

Loading

joragua commented Oct 9, 2024 •

edited

Loading