[TECHNICAL] Detekt: static code analyzer

[jesmrec]

Related Issues

App: #4506

• Add changelog files for the fixed issues in folder changelog/unreleased. More info here
• Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

---

QA

[JuancaG05]

Some comments to take into account before we merge 😃 @jesmrec

[JuancaG05]

We'll need to review this before merging, and probably remove it

[jesmrec]

This is totally intended at this point. That makes detekt to execute only in the current branch because the work is not finished. This will not be removed but replaced for a correct policy that we will agree in.

[JuancaG05]

Probably we want to run Detekt in every PR we do, not only in master (for which we cannot create PR), so this needs to be reviewed as well

[jesmrec]

Same as before. Intended and provisional.

[JuancaG05]

MaximumLineLength, from the "Formatting" section, is currently enabled. In the docs it says it overlaps with MaxLineLength, which we are relying on, and they have different values. Needs to be checked.

EDIT: "Formatting" section was not yet considered for this iteration, but we'll need to use the MaximumLineLength rule since it has the ignoreBackTickedIdentifier parameter, which allows to ignore the lines for the tests names with the backtick format, which we use and that currently exceed the line length limit (there is no way to break them in more than 1 line).

These reports will be avoided for the moment with @Suppress annotations, but once we enable MaximumLineLength they should be removed.

[JuancaG05]

Just checked (tested empirically) with the LongMethod rule that Detekt counts LLOC when talking about lines of code, and so I guess this happens with every rule that has to do with lines of code. That means, when trying to reduce lines of code, don't play with blank lines or comments since that won't make effect 😉