Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified bottom-nav-bar #4489

Closed
wants to merge 1 commit into from
Closed

modified bottom-nav-bar #4489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion owncloudApp/src/main/res/layout/nav_coordinator_layout.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,12 @@
android:visibility="visible"
app:itemIconTint="@color/primary_button_text_color"
app:itemTextColor="@color/primary_button_text_color"
app:labelVisibilityMode="auto"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:labelVisibilityMode="labeled"
app:activeIndicatorEnabled="true"
app:activeIndicatorColor="@color/active_indicator_color"
Comment on lines +57 to +58
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 2 attributes seem not to exist, at least on the version of the BottomNavigationView that we're using. You can check this because the app build fails (take a look at the BitRise checks or check it locally in your computer)

app:menu="@menu/bottom_navbar_menu" />

</androidx.constraintlayout.widget.ConstraintLayout>
1 change: 1 addition & 0 deletions owncloudApp/src/main/res/values/setup.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
<color name="actionbar_start_color">@color/primary</color>
<color name="primary_button_background_color">@color/color_accent</color>
<color name="primary_button_text_color">@color/white</color>
<color name="active_indicator_color">#3F51B5</color>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you decide this color? We should keep consistency as far as we can with colors in the app 😃. In this case, it may even not be necessary, the active indicator is enabled by default (with the color already provided in app:itemTextColor), but maybe you can play with app:itemActiveIndicatorStyle to see different options

<color name="secondary_button_background_color">#D6D7D7</color>
<color name="secondary_button_text_color">@color/black</color>
<color name="drawer_header_color">@color/owncloud_blue_accent</color>
Expand Down
Loading