Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TECHNICAL] Pending unit tests for OCRemoteServerInfoDataSource #4520

Merged
merged 1 commit into from
Nov 29, 2024
Merged

[TECHNICAL] Pending unit tests for OCRemoteServerInfoDataSource #4520

merged 1 commit into from
Nov 29, 2024

Conversation

JuancaG05
Copy link
Collaborator

@JuancaG05 JuancaG05 commented Nov 29, 2024 •
edited
Loading

Related Issues

App: #4517

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@JuancaG05 JuancaG05 self-assigned this Nov 29, 2024
@JuancaG05 JuancaG05 changed the title [TECHNICAL] Pending unit tests for OCRemoteServerInfoDataSource [TECHNICAL] Pending unit tests for OCRemoteServerInfoDataSource Nov 29, 2024
@JuancaG05 JuancaG05 linked an issue Nov 29, 2024 that may be closed by this pull request
[TECHNICAL] Pending unit tests for OCRemoteServerInfoDataSource #4517
Closed
6 tasks
@JuancaG05 JuancaG05 requested a review from joragua November 29, 2024 10:18
joragua
joragua approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@joragua joragua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @JuancaG05! Approved 🚀

@JuancaG05 JuancaG05 merged commit 15ce65d into master Nov 29, 2024
7 checks passed
@JuancaG05 JuancaG05 deleted the technical/tests_server_info_datasource branch November 29, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joragua joragua joragua approved these changes

Assignees

@JuancaG05 JuancaG05

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TECHNICAL] Pending unit tests for OCRemoteServerInfoDataSource
2 participants
@JuancaG05 @joragua