Adjust PHP unit tests for Symfony 5

owncloud · May 19, 2023 · 5877f12 · 5877f12
1 parent 8781afb
commit 5877f12
Show file tree

Hide file tree

Showing 7 changed files with 31 additions and 12 deletions.
diff --git a/apps/federatedfilesharing/tests/NotificationsTest.php b/apps/federatedfilesharing/tests/NotificationsTest.php
@@ -341,14 +341,14 @@ public function dataTryHttpPostToShareEndpointInException() {
 	public function testDeclineEvent() {
 		$dispatcher = \OC::$server->getEventDispatcher();
 		$event = $dispatcher->dispatch(
-			DeclineShare::class,
 			new DeclineShare(
 				[
 					'remote_id' => '4354353',
 					'remote' => 'http://localhost',
 					'share_token' => 'ohno'
 				]
-			)
+			),
+			DeclineShare::class
 		);
 		$this->assertInstanceOf(DeclineShare::class, $event);
 	}

diff --git a/apps/federation/tests/TrustedServersTest.php b/apps/federation/tests/TrustedServersTest.php
@@ -74,6 +74,12 @@ public function setUp(): void {
 			->disableOriginalConstructor()->getMock();
 		$this->dispatcher = $this->getMockBuilder('Symfony\Component\EventDispatcher\EventDispatcherInterface')
 			->disableOriginalConstructor()->getMock();
+		$this->dispatcher->expects($this->any())->method('dispatch')
+			->will(
+				$this->returnCallback(function ($object) {
+					return $object;
+				})
+			);
 		$this->httpClientService = $this->createMock('OCP\Http\Client\IClientService');
 		$this->httpClient = $this->createMock('OCP\Http\Client\IClient');
 		$this->response = $this->createMock('OCP\Http\Client\IResponse');

diff --git a/apps/files/tests/Controller/ViewControllerTest.php b/apps/files/tests/Controller/ViewControllerTest.php
@@ -75,6 +75,12 @@ public function setUp(): void {
 		$this->l10n = $this->createMock('\OCP\IL10N');
 		$this->config = $this->createMock('\OCP\IConfig');
 		$this->eventDispatcher = $this->createMock('\Symfony\Component\EventDispatcher\EventDispatcherInterface');
+		$this->eventDispatcher->expects($this->any())->method('dispatch')
+			->will(
+				$this->returnCallback(function ($object) {
+					return $object;
+				})
+			);
 		$this->userSession = $this->createMock('\OCP\IUserSession');
 		$this->appManager = $this->createMock('\OCP\App\IAppManager');
 		$this->user = $this->createMock('\OCP\IUser');

diff --git a/apps/files_sharing/tests/HooksTest.php b/apps/files_sharing/tests/HooksTest.php
@@ -147,7 +147,7 @@ public function testPrivateLink() {
 			'resolvedWebLink' => null,
 			'resolvedDavLink' => null,
 		]);
-		$this->eventDispatcher->dispatch('files.resolvePrivateLink', $event);
+		$this->eventDispatcher->dispatch($event, 'files.resolvePrivateLink');
 
 		$this->assertEquals('/owncloud/index.php/apps/files/?view=sharingin&scrollto=123', $event->getArgument('resolvedWebLink'));
 		$this->assertNull($event->getArgument('resolvedDavLink'));
@@ -168,7 +168,7 @@ public function testPrivateLinkNoMatch() {
 			'resolvedWebLink' => null,
 			'resolvedDavLink' => null,
 		]);
-		$this->eventDispatcher->dispatch('files.resolvePrivateLink', $event);
+		$this->eventDispatcher->dispatch($event, 'files.resolvePrivateLink');
 
 		$this->assertNull($event->getArgument('resolvedWebLink'));
 		$this->assertNull($event->getArgument('resolvedDavLink'));
@@ -182,7 +182,7 @@ public function testDeleteGroup() {
 		$this->sharingAllowlist->expects($this->once())->method('setPublicShareSharersGroupsAllowlist')->with([]);
 
 		$event = new GenericEvent($group);
-		$this->eventDispatcher->dispatch('group.postDelete', $event);
+		$this->eventDispatcher->dispatch($event, 'group.postDelete');
 	}
 
 	public function testPublishShareNotification() {
@@ -196,7 +196,7 @@ public function testPublishShareNotification() {
 			'share' => ['id' => '123'],
 			'shareObject' => $share,
 		]);
-		$this->eventDispatcher->dispatch('share.afterCreate', $event);
+		$this->eventDispatcher->dispatch($event, 'share.afterCreate');
 	}
 
 	public function testDiscardShareNotification() {
@@ -210,7 +210,7 @@ public function testDiscardShareNotification() {
 			'share' => ['id' => '123'],
 			'shareObject' => $share,
 		]);
-		$this->eventDispatcher->dispatch('share.afterDelete', $event);
+		$this->eventDispatcher->dispatch($event, 'share.afterDelete');
 	}
 
 	public function providesDataForCanGet() {
@@ -271,7 +271,7 @@ public function testCheckDirectCanBeDownloaded($path, $userFolder, $run) {
 
 		// Simulate direct download of file
 		$event = new GenericEvent(null, [ 'path' => $path ]);
-		$this->eventDispatcher->dispatch('file.beforeGetDirect', $event);
+		$this->eventDispatcher->dispatch($event, 'file.beforeGetDirect');
 
 		$this->assertEquals($run, !$event->hasArgument('errorMessage'));
 	}
@@ -349,7 +349,7 @@ public function testCheckZipCanBeDownloaded($dir, $files, $userFolder, $run) {
 
 		// Simulate zip download of folder folder
 		$event = new GenericEvent(null, ['dir' => $dir, 'files' => $files, 'run' => true]);
-		$this->eventDispatcher->dispatch('file.beforeCreateZip', $event);
+		$this->eventDispatcher->dispatch($event, 'file.beforeCreateZip');
 
 		$this->assertEquals($run, $event->getArgument('run'));
 		$this->assertEquals($run, !$event->hasArgument('errorMessage'));
@@ -360,7 +360,7 @@ public function testCheckFileUserNotFound() {
 
 		// Simulate zip download of folder folder
 		$event = new GenericEvent(null, ['dir' => '/test', 'files' => ['test.txt'], 'run' => true]);
-		$this->eventDispatcher->dispatch('file.beforeCreateZip', $event);
+		$this->eventDispatcher->dispatch($event, 'file.beforeCreateZip');
 
 		// It should run as this would restrict e.g. share links otherwise
 		$this->assertTrue($event->getArgument('run'));
@@ -394,7 +394,7 @@ public function testPublishShareSelfUnshareEvent() {
 			'shareRecipient' => 'recipient_user',
 			'shareOwner' => 'owner_user',
 		]);
-		$this->eventDispatcher->dispatch('fromself.unshare', $event);
+		$this->eventDispatcher->dispatch($event, 'fromself.unshare');
 	}
 
 	public function testExtendJsConfig() {

diff --git a/apps/files_trashbin/tests/TrashbinTest.php b/apps/files_trashbin/tests/TrashbinTest.php
@@ -565,7 +565,7 @@ public function testPrivateLink() {
 			'resolvedWebLink' => null,
 			'resolvedDavLink' => null,
 		]);
-		\OC::$server->getEventDispatcher()->dispatch('files.resolvePrivateLink', $event);
+		\OC::$server->getEventDispatcher()->dispatch($event, 'files.resolvePrivateLink');
 
 		$this->assertEquals('/owncloud/index.php/apps/files/?view=trashbin&dir=/test.d1462861890/sub&scrollto=somefile.txt', $event->getArgument('resolvedWebLink'));
 		$this->assertNull($event->getArgument('resolvedDavLink'));

diff --git a/tests/Core/Controller/RolesControllerTest.php b/tests/Core/Controller/RolesControllerTest.php
@@ -47,6 +47,7 @@ public function testGetAvatarNoAvatar() {
 				'id' => 'test.tester',
 				'displayName' => 'A tester which tests ....'
 			]);
+			return $event;
 		});
 
 		$result = $controller->getRoles();

diff --git a/tests/lib/Repair/AppsTest.php b/tests/lib/Repair/AppsTest.php
@@ -49,6 +49,12 @@ protected function setUp(): void {
 		$this->appManager = $this->createMock(IAppManager::class);
 		$this->defaults = $this->createMock(\OC_Defaults::class);
 		$this->eventDispatcher = $this->createMock(EventDispatcherInterface::class);
+		$this->eventDispatcher->expects($this->any())->method('dispatch')
+			->will(
+				$this->returnCallback(function ($object) {
+					return $object;
+				})
+			);
 		$this->config = $this->createMock(IConfig::class);
 		$this->repair = new Apps(
 			$this->appManager,