stream webdav downloads using http client

[icewind1991]

Extends the http client to allow streamed responses and uses that for dav downloads.

Replaces #10620

cc @PVince81 @LukasReschke @MorrisJobke

[ghost]

🚀 Test PASSed.🚀

[RobinMcCorkell]

Why use Guzzle instead of the Sabre DAV Client that is already used in that class? It supports streams as well, with nearly the same interface:

$request = new \Sabre\HTTP\Request('GET', $this->createBaseUri() . $this->encodePath($path));

$response = $this->client->send($request);

return $response->getBodyAsStream();

Also, you missed the cURL stuff in uploadFile().

[icewind1991]

From what I can tell that api doesn't actually stream the result, just returns the string result as a stream

cc @evert

[evert]

This is true.. It's been a feature request for a while: sabre-io/http#15

[RobinMcCorkell]

@evert As @DeepDiver1975 sometimes says... FIXIT! 😆

[evert]

I don't know how!

[icewind1991]

@Xenopathic @PVince81 @DeepDiver1975 can this be merged?

[PVince81]

$isStream ? Is it a boolean or can it be an actual stream ?

[icewind1991]

A boolean, to tell the Response class if it should treat the response as a stream

[PVince81]

Seems to work with federated shares 👍

Would be good to find out whether it works with valid SSL certs though. @LukasReschke what do you think ?

[RobinMcCorkell]

Still missing the other cURL stuff in uploadFile()

[RobinMcCorkell]

👍

[scrutinizer-notifier]

A new inspection was created.

[RobinMcCorkell]

👍

[icewind1991]

@PVince81 can you re-review with the latest changes

[icewind1991]

@DeepDiver1975 @MorrisJobke can you review this?

[LukasReschke]

👍