Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy into local file #22604

Merged
merged 2 commits into from
Feb 25, 2016
Merged

Copy into local file #22604

merged 2 commits into from
Feb 25, 2016

Commits on Feb 25, 2016

  1. Copy into local file 

    Using the Guzzle stream directly here will only return 1739 characters for `fread` instead of all data. This leads to the problem that the stream is read incorrectly and thus the data cannot be properly decrypted => 💣

This approach copies the data into a local temporary file, as done before in all stable releases as well as other storage connectors.

While this approach will load the whole file into memory, this is already was has happened before in any stable release as well. See d608c37 for the breaking change.

To test this enable Google Drive as external storage and upload some files with encryption enabled. Reading the file should fail now.

Fixes #22590
    @LukasReschke
    LukasReschke committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    3b5ddb4 View commit details
    Browse the repository at this point in the history

  2. More error handling

    @LukasReschke
    LukasReschke committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    aebb900 View commit details
    Browse the repository at this point in the history