[WIP] Adding symfony events for shares #30570
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharidas
changed the title
|
This PR is a deviation from #30268. This doesn't replace the old hooks, instead adds one. |
Codecov Report
@@ Coverage Diff @@
## master #30570 +/- ##
============================================
+ Coverage 61.61% 61.62% +0.01%
- Complexity 18507 18508 +1
============================================
Files 1090 1090
Lines 61112 61136 +24
============================================
+ Hits 37653 37677 +24
Misses 23459 23459
Continue to review full report at Codecov.
|
sharidas
force-pushed
the
new-symfony-events-updated
branch
2 times, most recently
from
3280205 to
6aa850f
Compare
Adding before and after events for shares using symfony's event dispatcher. Signed-off-by: Sujith H <[email protected]>
sharidas
force-pushed
the
new-symfony-events-updated
branch
from
6aa850f to
0ce660c
Compare
|
is this obsolete ? |
Yes this is obsolete PR. I am closing this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding before and after events for shares
using symfony's event dispatcher.
Signed-off-by: Sujith H [email protected]
Description
Adding before and after symfony dispatcher events for shares
Related Issue
Motivation and Context
Adding before and after symfony dispatcher events for shares.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: