Remove $CLASSPATH - this is no longer needed. Apps are using proper n…

[DeepDiver1975]

…amespaces today.

Description

$CLASSPATH as a very old concept to perform auto loading in ownCloud.

As of today all apps use a proper namespace e.g. OCA\Calendar\ to load classes living in the calendar app.

Furthermore composer is more and more used and has a far better autoloaded then ownCloud itself.

Issues

closes #12573

Motivation and Context

Deprecate/remove old concepts

How Has This Been Tested?

• manually
• unit tests

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

Open tasks:

• Backport (if applicable set "backport-request" label and remove when the backport was done)

[PVince81]

manually

retested SMB storage and OC ext storage config ?

[DeepDiver1975]

retested SMB storage and OC ext storage config ?
Merge state

I made sure in debugger that the class is loaded and can be used - which is the case in app.php.
No further testing necessary from my pov

[DeepDiver1975]

Issues raised:

• Stop using $CLASSPATH owncloud-archive/SMStorage#5
• Stop using $CLASSPATH owncloud-archive/apps#2228
• https://github.com/owncloud/ownbrander/issues/815

[PVince81]

👍 thanks

[codecov]

Codecov Report

Merging #32203 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master   #32203      +/-   ##
============================================
+ Coverage      63.9%    63.9%   +<.01%     
+ Complexity    18548    18543       -5     
============================================
  Files          1169     1169              
  Lines         69732    69722      -10     
  Branches       1267     1267              
============================================
- Hits          44560    44559       -1     
+ Misses        24803    24794       -9     
  Partials        369      369

Flag	Coverage Δ	Complexity Δ
#javascript	52.81% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	65.18% <100%> (ø)	18543 <0> (-5)	⬇️

Impacted Files	Coverage Δ	Complexity Δ
apps/files_external/appinfo/app.php	0% <ø> (ø)	0 <0> (ø)	⬇️
lib/autoloader.php	93.33% <100%> (+13.7%)	22 <0> (-5)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a811f5...047a2aa. Read the comment docs.

[DeepDiver1975]

there seems to be something wrong with the phpunit test execution - AutoloadTest shall fail .....

[phil-davis]

Backport stable10 #35755