Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip failing tests in files_primary_s3 #35617

Merged
merged 1 commit into from
Jun 21, 2019
Merged

Skip failing tests in files_primary_s3 #35617

merged 1 commit into from
Jun 21, 2019

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented Jun 21, 2019

Description

After owncloud/files_primary_s3#128 got fixed some core tests that were skipped in files_primary_s3 were unskipped. But the fix have raised another issue (owncloud/files_primary_s3#224). so the tests need to be skipped again.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov
Copy link

codecov bot commented Jun 21, 2019

Codecov Report

Merging #35617 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35617   +/-   ##
=========================================
  Coverage     65.68%   65.68%           
  Complexity    18775    18775           
=========================================
  Files          1222     1222           
  Lines         70932    70932           
  Branches       1289     1289           
=========================================
  Hits          46594    46594           
  Misses        23960    23960           
  Partials        378      378
Flag Coverage Δ Complexity Δ
#javascript 53.7% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.05% <ø> (ø) 18775 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee2a647...b75b5be. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 21, 2019

Codecov Report

Merging #35617 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35617   +/-   ##
=========================================
  Coverage     65.68%   65.68%           
  Complexity    18775    18775           
=========================================
  Files          1222     1222           
  Lines         70932    70932           
  Branches       1289     1289           
=========================================
  Hits          46594    46594           
  Misses        23960    23960           
  Partials        378      378
Flag Coverage Δ Complexity Δ
#javascript 53.7% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.05% <ø> (ø) 18775 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee2a647...b75b5be. Read the comment docs.

@dpakach dpakach merged commit cb7c022 into master Jun 21, 2019
@delete-merged-branch delete-merged-branch bot deleted the skip-files_s3 branch June 21, 2019 08:30
@dpakach
Copy link
Contributor Author

dpakach commented Jun 21, 2019

Backport #35619

@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants