Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip on oc v10.3 20191223 for 10.4 #36631

Merged
merged 3 commits into from
Dec 23, 2019

Conversation

phil-davis
Copy link
Contributor

Description

cherry-pick of PR #36624 - correctly skip scenarios if testing against old core 10.3

Related Issue

owncloud/files_primary_s3#293
owncloud/files_primary_s3#294

Motivation and Context

Get these skip tage correct in the 10.4 release branch also, so that if we are running some app CI against release-10.4.0 branch, that we do not get problems with drone pipelines that also run against latest 10.3

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

Copy link
Contributor

@dpakach dpakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codecov
Copy link

codecov bot commented Dec 23, 2019

Codecov Report

❗ No coverage uploaded for pull request base (release-10.4.0@61096fe). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##             release-10.4.0   #36631   +/-   ##
=================================================
  Coverage                  ?   64.68%           
  Complexity                ?    19105           
=================================================
  Files                     ?     1269           
  Lines                     ?    74721           
  Branches                  ?     1320           
=================================================
  Hits                      ?    48333           
  Misses                    ?    26000           
  Partials                  ?      388
Flag Coverage Δ Complexity Δ
#javascript 54.12% <ø> (?) 0 <ø> (?)
#phpunit 65.85% <ø> (?) 19105 <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61096fe...fba8732. Read the comment docs.

@phil-davis phil-davis merged commit 5c78279 into release-10.4.0 Dec 23, 2019
@delete-merged-branch delete-merged-branch bot deleted the skipOnOcV10.3-20191223-for-10.4 branch December 23, 2019 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants