-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 36925 #36926
Fix issue 36925 #36926
Conversation
a746f3b
to
dd26d40
Compare
dd26d40
to
6d96b45
Compare
@micbar I am investigating owncloud/user_ldap#509 which is about some test fails with user_ldap+encryption. While looking at that, I found this bug with the unusual combination described in issue #36925 It would be useful if you or some developer can review my code fix. If I can get it merged, then the nightly tests will run with this bit fixed. Then I can see the nightly results and think what to touch next. |
6d96b45
to
839ecd4
Compare
839ecd4
to
268440d
Compare
Codecov Report
@@ Coverage Diff @@
## master #36926 +/- ##
============================================
- Coverage 65.53% 63.98% -1.55%
- Complexity 19135 19136 +1
============================================
Files 1207 1270 +63
Lines 67370 74875 +7505
Branches 0 1329 +1329
============================================
+ Hits 44150 47908 +3758
- Misses 23220 26576 +3356
- Partials 0 391 +391
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests look good!
Description
1st commit: Add test scenario to demonstrate the problem with:
(using both these command options together)
2nd commit: fix the problem. Add code to check that the user does have an email address (similar to the checks done higher up in the case when generating/sending a password-reset link)
Related Issue
How Has This Been Tested?
Local run of test scenario
Types of changes
Checklist: