Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Skip on encryption more test scenarios #36988

Merged
merged 2 commits into from
Feb 20, 2020

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Feb 20, 2020

Description

skipOnEncryptionType:user-keys for CLI acceptance test scenarios that do not work with user-key encryption. See the issues for details.

This will get owncloud/encryption#179 passing, so we can regularly run core CLI acceptance tests in drone.

Related Issue

owncloud/encryption#181
owncloud/encryption#182

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis self-assigned this Feb 20, 2020
@owncloud owncloud deleted a comment from update-docs bot Feb 20, 2020
@phil-davis phil-davis changed the title [Test-Only] Skip on encryption more test scenarios [Tests-Only] Skip on encryption more test scenarios Feb 20, 2020
@codecov
Copy link

codecov bot commented Feb 20, 2020

Codecov Report

Merging #36988 into master will decrease coverage by 0.34%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #36988      +/-   ##
============================================
- Coverage     64.62%   64.28%   -0.35%     
  Complexity    19138    19138              
============================================
  Files          1270     1270              
  Lines         74912    74877      -35     
  Branches       1329     1329              
============================================
- Hits          48411    48131     -280     
- Misses        26110    26355     +245     
  Partials        391      391              
Flag Coverage Δ Complexity Δ
#javascript 54.17% <ø> (ø) 0.00 <ø> (ø) ⬆️
#phpunit 65.40% <ø> (-0.39%) 19138.00 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
lib/private/DB/PostgreSqlMigrator.php 0.00% <0.00%> (-100.00%) 4.00% <0.00%> (ø%)
...ilder/ExpressionBuilder/PgSqlExpressionBuilder.php 0.00% <0.00%> (-88.89%) 3.00% <0.00%> (ø%)
...ivate/Files/ObjectStore/HomeObjectStoreStorage.php 0.00% <0.00%> (-86.67%) 8.00% <0.00%> (ø%)
lib/private/DB/AdapterPgSql.php 0.00% <0.00%> (-85.72%) 2.00% <0.00%> (ø%)
lib/private/Files/Storage/Wrapper/Availability.php 10.38% <0.00%> (-40.26%) 80.00% <0.00%> (ø%)
lib/private/Files/ObjectStore/NoopScanner.php 68.75% <0.00%> (-18.75%) 6.00% <0.00%> (ø%)
lib/private/Preview/MP3.php 45.16% <0.00%> (-12.91%) 13.00% <0.00%> (ø%)
lib/private/Autoloader.php 80.48% <0.00%> (-12.20%) 20.00% <0.00%> (ø%)
...b/private/Files/ObjectStore/ObjectStoreStorage.php 66.20% <0.00%> (-11.04%) 105.00% <0.00%> (ø%)
lib/private/App/Platform.php 21.73% <0.00%> (-8.70%) 9.00% <0.00%> (ø%)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 504628c...52d3866. Read the comment docs.

@phil-davis phil-davis merged commit cff79f5 into master Feb 20, 2020
@delete-merged-branch delete-merged-branch bot deleted the skipOnEncryption-more-test-scenarios branch February 20, 2020 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants