Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Skip tests that fail due to issue-files_primary_s3-387 #37969

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

phil-davis
Copy link
Contributor

Description

These new etag-propagation tests fail on S3 storage - see the issue.
Skip them on S3 storage.

Related Issue

owncloud/files_primary_s3#387

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #37969 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37969   +/-   ##
=========================================
  Coverage     64.72%   64.72%           
  Complexity    19445    19445           
=========================================
  Files          1286     1286           
  Lines         76037    76037           
  Branches       1336     1336           
=========================================
  Hits          49213    49213           
  Misses        26430    26430           
  Partials        394      394           
Flag Coverage Δ Complexity Δ
#javascript 54.06% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.89% <ø> (ø) 19445.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 817b141...7311a7b. Read the comment docs.

@phil-davis phil-davis merged commit 93831ac into master Oct 2, 2020
@delete-merged-branch delete-merged-branch bot deleted the issue-files_primary_s3-387 branch October 2, 2020 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants