Skip to content
This repository has been archived by the owner on Jun 21, 2024. It is now read-only.

Always return an int from Symfony Command execute method #221

Merged
merged 1 commit into from
May 18, 2023

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented May 18, 2023

Description

Symfony 5 will require this, so be prepared.
For Symfony 4 it is optional.

Preparation for owncloud/core#39630

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@phil-davis phil-davis self-assigned this May 18, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@phil-davis phil-davis requested a review from jvillafanez May 18, 2023 09:41
@phil-davis phil-davis merged commit d0a89d3 into master May 18, 2023
@delete-merged-branch delete-merged-branch bot deleted the symfony-command-execute-int branch May 18, 2023 10:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants