Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump eslint-config-standard from 14.1.1 to 16.0.2 #236

Merged

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Dec 21, 2020

Bumps eslint-config-standard from 14.1.1 to 16.0.2.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Dec 21, 2020
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/eslint-config-standard-16.0.2 branch from 5ca87f6 to d940bac Compare December 24, 2020 03:30
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/eslint-config-standard-16.0.2 branch 3 times, most recently from 23274ab to 528902d Compare January 5, 2021 03:08
@phil-davis
Copy link
Contributor

@micbar who should look into this sort of dependency bump?
IMO it is "a good thing" to try and keep up with dependencies, otherwise it gets harder and harder in the future.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/eslint-config-standard-16.0.2 branch from 528902d to 74a55f5 Compare January 7, 2021 03:08
@micbar
Copy link

micbar commented Jan 7, 2021

I put it on the server DEV board.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/eslint-config-standard-16.0.2 branch from 74a55f5 to b00a4bc Compare January 8, 2021 02:15
@karakayasemi
Copy link

karakayasemi commented Jan 11, 2021

The cause of the problem is gulp-eslint library: adametry/gulp-eslint#250

gulp-eslint library has own old version eslint dependency and looks like it has not active repository anymore, last code update is 1.5 years ago. To update this dependency, one option would be migrating gulp-eslint7 which is a community fork of gulp-eslint: https://github.com/fasttime/gulp-eslint7

@AlexAndBear
Copy link
Contributor

AlexAndBear commented Jan 12, 2021

@karakayasemi I would likeley go with the "resolutions" option in the package.json.
The gulp-eslint7 package is not wideley-spreaded and don't do anything else.
Possible fix:
#243

@phil-davis @micbar
what would you vote for? maybe we should not upgrade here?

@karakayasemi
Copy link

@janackermann seems reasonable. Fine by me to go with resolutions option.

@phil-davis
Copy link
Contributor

what would you vote for? maybe we should not upgrade here?

I don't like "not upgrading" for any dependencies. That just means that in a year or 2 the repo will be completely "stuck" and...

PR #243 works

@AlexAndBear
Copy link
Contributor

@phil-davis 👍 I don't know dependabot, it is enough to merge my PR to master?

@AlexAndBear AlexAndBear merged commit b00a4bc into master Jan 12, 2021
@delete-merged-branch delete-merged-branch bot deleted the dependabot/npm_and_yarn/eslint-config-standard-16.0.2 branch January 12, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants