-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
occ LDAP update #4300
occ LDAP update #4300
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor language improvements.
..._manual/pages/configuration/server/occ_commands/app_commands/_ldap_integration_commands.adoc
Outdated
Show resolved
Hide resolved
5d09215
to
7d87586
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some added details and precision.
..._manual/pages/configuration/server/occ_commands/app_commands/_ldap_integration_commands.adoc
Show resolved
Hide resolved
..._manual/pages/configuration/server/occ_commands/app_commands/_ldap_integration_commands.adoc
Outdated
Show resolved
Hide resolved
..._manual/pages/configuration/server/occ_commands/app_commands/_ldap_integration_commands.adoc
Outdated
Show resolved
Hide resolved
..._manual/pages/configuration/server/occ_commands/app_commands/_ldap_integration_commands.adoc
Outdated
Show resolved
Hide resolved
ae541e7
to
7205cfa
Compare
..._manual/pages/configuration/server/occ_commands/app_commands/_ldap_integration_commands.adoc
Outdated
Show resolved
Hide resolved
..._manual/pages/configuration/server/occ_commands/app_commands/_ldap_integration_commands.adoc
Show resolved
Hide resolved
@jvillafanez info: the texts from the options and arguments are not freely written but come when you use |
Ok, got it. The first one (the search argument) has a different help message in the release: just "the search string (can be empty)", which seems lacking. That's why I thought the documentation would include some additional information. We can't write a wall of text in a help message. For the second one, I don't think it's critical, so we can leave it as it is. |
Will do my very best (Dinner for One) 😅 |
7205cfa
to
703f911
Compare
@jvillafanez mind to have a look at the search changes if they are ok to you (pls try to reword in case they are not...) |
..._manual/pages/configuration/server/occ_commands/app_commands/_ldap_integration_commands.adoc
Outdated
Show resolved
Hide resolved
f190e58
to
c40a771
Compare
It needs more clarification text with regards of multiple values when using |
c40a771
to
5b9717e
Compare
The document is updated and contains now all changes and explanations. @jvillafanez mind to have a final look on it before we merge? |
This PR is a bigger update of the occ ldap command set as it was a complete mess.
Fixes: #3901 (New LDAP command to invalidate the cache)
Merging when owncloud/user_ldap#681 (LDAP 0.16.0) is close to final.
When merged, the occ ldap command reference can safely be included in the ldap documentation when it gets revised.
Backport to 10.9 and 10.8
@jvillafanez fyi