Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] [full-ci] Start federated server for core-cli test pipelines #324

Merged
merged 2 commits into from
Feb 18, 2022

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Feb 17, 2022

Issue owncloud/core#39799

2nd commit - Add expected-failure for issue #326 (see comments below and the issue)

After merging this, we can rebase #325 and get that passing and merge it.

@phil-davis phil-davis self-assigned this Feb 17, 2022
@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline cliCoreMKey-7-3-master-mysql8.0-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/encryption/2312/70/1

@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline cliCoreMKey-7-3-master-mysql8.0-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/encryption/2313/70/1

@phil-davis
Copy link
Contributor Author

https://drone.owncloud.com/owncloud/encryption/2313/70/18

runsh: Total unexpected failed scenarios throughout the test run:
cliExternalStorage/filesExternalWebdavOwncloud.feature:270
  Scenario: user moves their own file to the external storage                                                                           # /var/www/owncloud/testrunner/tests/acceptance/features/cliExternalStorage/filesExternalWebdavOwncloud.feature:270
    Given user "Alice" has been created with default attributes and without skeleton files                                              # FeatureContext::userHasBeenCreatedWithDefaultAttributesAndWithoutSkeletonFiles()
    And the administrator has created an external mount point with the following configuration about user "Alice" using the occ command # OccContext::adminHasCreatedAnExternalMountPointWithFollowingConfigUsingTheOccCommand()
      | host                   | %remote_server%    |
      | root                   | TestMnt            |
      | secure                 | false              |
      | user                   | %username%         |
      | password               | %password%         |
      | storage_backend        | owncloud           |
      | mount_point            | TestMountPoint     |
      | authentication_backend | password::password |
    And user "Alice" has uploaded file with content "Test content for moving file." to "test.txt"                                       # FeatureContext::userHasUploadedAFileWithContentTo()
    When user "Alice" moves file "/test.txt" to "TestMountPoint/test.txt" using the WebDAV API                                          # FeatureContext::userMovesFileUsingTheAPI()
    Then the HTTP status code should be "201"                                                                                           # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    And as "Alice" file "TestMountPoint/test.txt" should exist                                                                          # FeatureContext::asFileOrFolderShouldExist()
    And using server "REMOTE"                                                                                                           # FeatureContext::usingServer()
    And as "Alice" file "TestMnt/test.txt" should exist                                                                                 # FeatureContext::asFileOrFolderShouldExist()
    And the content of file "TestMnt/test.txt" for user "Alice" should be "Test content for moving file."                               # FeatureContext::contentOfFileForUserShouldBe()
      The downloaded content was expected to be 'Test content for moving file.', but actually is 'HBEGIN:oc_encryption_module:OC_DEFAULT_MODULE:cipher:AES-256-CTR:signed:true:encoding:binary:HEND

When the encrypted file is moved out of the local storage and onto the external mount point, it looks like it is not decrypted.

IMO there is already an issue about this sort of thing. I will find the issue number and skip the test when running with encryption...

@phil-davis phil-davis changed the title [tests-only] Start federated server for core-cli test pipelines [tests-only] [full-ci] Start federated server for core-cli test pipelines Feb 17, 2022
@phil-davis phil-davis force-pushed the core-cli-federated-server branch from c3501d1 to 8db00cd Compare February 17, 2022 12:41
@phil-davis
Copy link
Contributor Author

IMO there is already an issue about this sort of thing. I will find the issue number and skip the test when running with encryption...

I didn't find an issue like this that is open. So I opened #326 for discussion.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis
Copy link
Contributor Author

https://drone.owncloud.com/owncloud/encryption/2318/69/18

Checking expected failures in /var/www/owncloud/testrunner/apps/encryption/tests/acceptance/expected-failures-cli.md
Features are expected to be in the owncloud/core repo
No problems were found in the expected failures file

I added an expected-failures file that links to issue #326

This lets us get CI passing again, and we can adjust the scenario (in core) and the expected-failures in the future, after the issue has been discussed.

@kiranparajuli589 kiranparajuli589 merged commit f1bb09a into master Feb 18, 2022
@delete-merged-branch delete-merged-branch bot deleted the core-cli-federated-server branch February 18, 2022 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants