-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot connect #2
Comments
PR here #6 |
looks like a lot of the SDK APIs have changed...that will need a lot of work... unless we decide to revert back to the old SDK version just for now (which also works with the old Guzzle). Seems a lot will depend on the Guzzle decision |
Yes there are API changes in the SDK because it's in BETA and they change whenever they feel like it. One of the errors - storage test fails because exception is thrown https://github.com/owncloud/files_external_gdrive/blob/master/lib/Storage/Google.php#L645 Response sent by {"id":30,"mountPoint":"\/GoogleDrive","backend":"googledrive","authMechanism":"oauth2::oauth2","backendOptions":{"configured":"true","client_id":"client_id","client_secret":"client_secret","token":"{\"access_token\":\"hash\",\"token_type\":\"Bearer\",\"expires_in\":3600,\"refresh_token\":\"some_value\",\"created\":1499226334}"},"priority":100,"mountOptions":{"encrypt":true,"previews":true,"enable_sharing":false,"filesystem_check_changes":1,"encoding_compatibility":false},"status":1,"statusMessage":"Google_Service_Exception: {\n \"error\": {\n \"errors\": [\n {\n \"domain\": \"global\",\n \"reason\": \"required\",\n \"message\": \"The 'fields' parameter is required for this method.\",\n \"locationType\": \"parameter\",\n \"location\": \"fields\"\n }\n ],\n \"code\": 400,\n \"message\": \"The 'fields' parameter is required for this method.\"\n }\n}\n","userProvided":false,"type":"system"} |
@PVince81 @DeepDiver1975 There is a flysystem adapter for Google Drive https://github.com/nao-pon/flysystem-google-drive |
@Hemant-Mann that could be a good idea, yes. My original concern was that it would take a while to do the port but then if it anyway would take a lot of time to port to the new SDK, then the move to flysystem could be worthwhile, assuming that the adapter is being maintained. I think a few months/years ago when we looked at flysystem there was no GDrive adapter yet. @Hemant-Mann as someone who ported Dropbox to the flysystem adapter, how much time do you think it would take to do the same for the GDrive implementation ? Note that GDrive has a few twists like allowing multiple files with the same name to exist within the same folder... and Google Docs must use an export API to be downloaded... so likely more work than for Dropbox. |
let's continue the flysystem discussion here: #7 |
Fix is here: #8 |
If oauth tokens were setup before upgrading to this app, the authorization does work.
But there seem to be API differences to the version there was in OC core.
Since here we use composer, it likely pulled a more recent version of the SDK so the code will need adjusting.
That, or find out what version we had before and force composer to use that one.
But I think we should rather focus on the latest version because we'll eventually want all this to work with Guzzle v6 (see owncloud/core#28063)
The text was updated successfully, but these errors were encountered: