Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use flysystem adapter #7

Open
PVince81 opened this issue Jul 11, 2017 · 5 comments
Open

Use flysystem adapter #7

PVince81 opened this issue Jul 11, 2017 · 5 comments

Comments

@PVince81
Copy link
Contributor

https://github.com/nao-pon/flysystem-google-drive

as suggested by @Hemant-Mann here #2 (comment)

@PVince81 PVince81 mentioned this issue Jul 11, 2017
@Hemant-Mann
Copy link
Contributor

@Hemant-Mann that could be a good idea, yes. My original concern was that it would take a while to do the port but then if it anyway would take a lot of time to port to the new SDK, then the move to flysystem could be worthwhile, assuming that the adapter is being maintained.

The Adapter is available on composer with support for both v2 and v3 API so I think it's currently maintained. We can clarify further with the developer if needed by creating an issue

@Hemant-Mann
Copy link
Contributor

Hemant-Mann commented Jul 11, 2017

@Hemant-Mann as someone who ported Dropbox to the flysystem adapter, how much time do you think it would take to do the same for the GDrive implementation ? Note that GDrive has a few twists like allowing multiple files with the same name to exist within the same folder... and Google Docs must use an export API to be downloaded... so likely more work than for Dropbox.

@PVince81 Yes I think GDrive implementation would require some more time compared to Dropbox because of the twists you mentioned. The current stable 10 implementation also checks for duplicate filenames Storage/Google.php.
I think downloading should not be much of an issue if user has sufficient permissions to download the file, according to the docs https://developers.google.com/drive/v3/web/manage-downloads export API are provided by the SDK itself :)

@PVince81
Copy link
Contributor Author

I won't have time to do this myself, so unless you have some time to do it after your Dropbox port, I'd leave this aside and focus on making this GDrive repo mirror whatever we had in core before, with minor changes to make it work with your oauth2 event changes.

@pmaier1 pmaier1 added this to the development milestone Oct 9, 2017
@PVince81 PVince81 modified the milestones: development, triage Apr 24, 2018
@hodyroff
Copy link

hodyroff commented Jun 6, 2018

This will also bring Team Drive Support https://github.com/nao-pon/flysystem-google-drive/blob/master/src/GoogleDriveAdapter.php
Users who have their data in team drive, can't access the data with our current implementation.

@Hemant-Mann
Copy link
Contributor

Okay so do we have any plan on updating the app?

I think the major task is the verification i.e working of app, if we have proper tests setup then this app can be easily converted to use the flysystem implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants