-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[+] Exif Description #453
base: master
Are you sure you want to change the base?
[+] Exif Description #453
Conversation
Thanks! @jancborchardt and his team can check the design. |
'name' => 'files#exif', | ||
'url' => '/files/exif', | ||
'verb' => 'GET' | ||
], | ||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The public routes will need the same endpoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Thanks for the fixes. How long can descriptions be? |
3 seconds as control. enough to read. then goes out to show the full picture. |
Wait, so you mean, this is blocking the rendering of the picture? First the description is shown for 3 seconds, then it's replaced by the image and cannot be seen again? |
no, no. :) description show over pictures, and may close the necessary detail in the picture... |
OK, but how big can that description be? If it can be as long as it wants, we may need to limit it to maybe 2 lines and reveal the rest on hover. |
css already in one line |
Yes, but that's for the title, so it's not a problem if we're missing 10% of the filename because there isn't enough space, but if we only get one line out of 10 for a description, then it's going to be frustrating for users. |
Yes you are right. some people may be stored there stories. |
Can you provide a few samples with stories stored in EXIF data? |
No I can not. I keep a few words describing the photo. |
@0xb0ba can you post a screenshot of this change so it’s easier to review? |
Thanks for that @0xb0ba. Designers need to figure out how to properly show that description.
A lot of galleries show the exif data in a side-bar. I think it would make it easier to show the meta-data we have. |
@oparoz, I'm not a designer. I can not answer these questions. in most cases it is the description of a few words, scroller or rollover is likely not needed. exif data need not always. its cool in popup side-bar. description should always, especially in the slideshow. |
I’m not sure we should show it there to be honest. What’s the usecase for exif description like that, I have never seen it really. How do other photo apps approach this? |
Thanks for the screenshot @0xb0ba. What happens on Picasa when you switch to portrait mode? |
@oparoz Sorry, I only have loads of pictures with GPS tags but no comments ... |
@patman15, gps tags its next step :) |
@0xb0ba, okidoki let me know when it's ready, I can test that. :-) |
Thanks. That works quite well for landscape pictures shown in portrait mode, but would cover 1/3 of a portrait. |
It's not a problem. it hides after 3 seconds. |
The default timer is for the whole interface, so it is a problem when zooming in/out as there is a large block of text masking part of the image. |
its not problem too - 0xb0ba@add90f0 |
what is the probability that the block will be large? |
show exif description (if exists) instead filename on preview and slideshow
TODO
Designers need to figure out how to properly show that description.
A lot of galleries show the exif data in a side-bar.