[Tests-Only] Refactor acceptance tests #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-davis
commented
Mar 2, 2020
| @@ -169,19 +169,6 @@ Feature: Guests | |||
| Then the OCS status code should be "404" | |||
| And the HTTP status code should be "200" | |||
|
|
|||
| Scenario: Check that skeleton is properly set | |||
There was a problem hiding this comment.
This scenario was not related to guests at all
phil-davis
commented
Mar 2, 2020
| /** | ||
| * @return string|null | ||
| */ | ||
| public function getGuestGroupName() { |
There was a problem hiding this comment.
This function was not used.
phil-davis
commented
Mar 2, 2020
| * @return void | ||
| * @throws Exception | ||
| */ | ||
| public function guestUserHasBeenCreatedWithEmailAndPassword($user, $email, $password) { |
There was a problem hiding this comment.
This function was not used.
Codecov Report
@@ Coverage Diff @@
## master #394 +/- ##
=========================================
Coverage 17.85% 17.85%
Complexity 96 96
=========================================
Files 11 11
Lines 532 532
=========================================
Hits 95 95
Misses 437 437 Continue to review full report at Codecov.
|
individual-it
approved these changes
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before adding new test scenarios for PR #384 , refactor the existing acceptance tests:
GivenandWhenstepsAssertchecksHow Has This Been Tested?
Local run of acceptance tests
Types of changes
Checklist: