-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On initial install impersonations icons shown but not possible because not configured #136
Comments
Blocker to a release IMO because since #134 the app is installed with a unusable configuration and none of the icons work with no explanation. |
@tomneedham In most of the cases the impersonation to a newly created user fails because, the newly created user has not logged in at least once. I hope you are pointing to this issue, right? If so, this is by design. Let me know if we are on the same page here :) ( don't take me wrongly ) |
Ah maybe this is the case.... I didn't know because I couldn't see the error. I thought there was no defualt configuration given the new change. |
ref #17 |
I got a small idea. Inorder to hide the users who have not logged in at least once:
But there are other cases, like nested impersonation ( which is obviously out of scope of this ticket ). In such cases we might have to think how to handle it by analysing response from the server. Meaning changes would have to be made in the server so that client analyses the response and shows/does not show impersonate icon. |
@tomneedham what timeline for release is needed? In any case of escalation, please find assignment with @PVince81 |
after discussing we clarified that the issue already existed and was accepted as "by design for now" with #17 so I think this should be put down to p3 until the concern for #17 becomes bigger @tomneedham can you confirm ? |
Correct. Sorry, I misused p1 here as "must have next release". And yes, clarified, can be p3 - no decrese in functionality. |
From the UI perspective it would help users to understand who can be impersonated. Instead of showing icons listed who may/may not be impersonated.
The text was updated successfully, but these errors were encountered: