Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On initial install impersonations icons shown but not possible because not configured #136

Open
sharidas opened this issue Feb 1, 2019 · 8 comments

Comments

@sharidas
Copy link
Contributor

sharidas commented Feb 1, 2019

From the UI perspective it would help users to understand who can be impersonated. Instead of showing icons listed who may/may not be impersonated.

@tomneedham tomneedham changed the title Remove impersonate icons for users who have not logged in once On initial install impersonations icons shown but not possible because not configured Feb 1, 2019
@tomneedham
Copy link
Contributor

Blocker to a release IMO because since #134 the app is installed with a unusable configuration and none of the icons work with no explanation.

@sharidas
Copy link
Contributor Author

sharidas commented Feb 3, 2019

@tomneedham In most of the cases the impersonation to a newly created user fails because, the newly created user has not logged in at least once. I hope you are pointing to this issue, right? If so, this is by design. Let me know if we are on the same page here :) ( don't take me wrongly )

@tomneedham
Copy link
Contributor

Ah maybe this is the case.... I didn't know because I couldn't see the error. I thought there was no defualt configuration given the new change.

@PVince81
Copy link
Contributor

PVince81 commented Feb 4, 2019

ref #17

@sharidas
Copy link
Contributor Author

sharidas commented Feb 5, 2019

I got a small idea. Inorder to hide the users who have not logged in at least once:

  • We get the data of each users in a row.
    1. When the data of a user is arrived, it does have lastlogin ( or lastLogin, I am not able to recollect it now ), <td>. May be we can check what is the status and allow to show that.

But there are other cases, like nested impersonation ( which is obviously out of scope of this ticket ). In such cases we might have to think how to handle it by analysing response from the server. Meaning changes would have to be made in the server so that client analyses the response and shows/does not show impersonate icon.

@felixboehm
Copy link

felixboehm commented Feb 12, 2019

@tomneedham what timeline for release is needed?
This p1 and needs a hotfix? Or can we set p2 for "must have" in next release?

In any case of escalation, please find assignment with @PVince81

@PVince81
Copy link
Contributor

after discussing we clarified that the issue already existed and was accepted as "by design for now" with #17

so I think this should be put down to p3 until the concern for #17 becomes bigger

@tomneedham can you confirm ?

@tomneedham
Copy link
Contributor

Correct. Sorry, I misused p1 here as "must have next release". And yes, clarified, can be p3 - no decrese in functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants