Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Adjust for Symfony5 #231

Merged
merged 1 commit into from
May 23, 2023
Merged

[full-ci] Adjust for Symfony5 #231

merged 1 commit into from
May 23, 2023

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented May 23, 2023 •
edited
Loading

  1. add controller code to phpstan so it gets analyzed.
  2. fixup calls to Symfony event dispatch()
  3. fixup other things reported by phpstan

Fixes #229
Fixes #230

Release issue is #232

@phil-davis phil-davis self-assigned this May 23, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@phil-davis phil-davis mentioned this pull request May 23, 2023
Closed
@phil-davis phil-davis requested review from SwikritiT and saw-jan May 23, 2023 06:27
@phil-davis phil-davis merged commit 3f226af into master May 23, 2023
@delete-merged-branch delete-merged-branch bot deleted the adjust-for-symfony5 branch May 23, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

Assignees

@phil-davis phil-davis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Web ui tests are failing in nightly Php-unit tests failing in nightly
2 participants
@phil-davis @saw-jan