Merge pull request #1233 from owncloud/symfony-command-execute-int

Always return an int from Symfony Command execute method
owncloud · May 18, 2023 · 3cde0d3 · 3cde0d3
2 parents fcfaa3d + 68ffa32
commit 3cde0d3
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 7 deletions.
diff --git a/lib/Command/InstallApp.php b/lib/Command/InstallApp.php
@@ -66,10 +66,10 @@ protected function configure() {
 	/**
 	 * @param InputInterface $input
 	 * @param OutputInterface $output
-	 * @return int|null
+	 * @return int
 	 * @throws \Exception
 	 */
-	protected function execute(InputInterface $input, OutputInterface $output) {
+	protected function execute(InputInterface $input, OutputInterface $output): int {
 		if (!$this->marketService->canInstall()) {
 			throw new \Exception("Installing apps is not supported because the app folder is not writable.");
 		}

diff --git a/lib/Command/ListApps.php b/lib/Command/ListApps.php
@@ -23,7 +23,6 @@
 
 use OCA\Market\MarketService;
 use Symfony\Component\Console\Command\Command;
-use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 
@@ -41,7 +40,7 @@ protected function configure() {
 			->setDescription('Lists apps as available on the marketplace.');
 	}
 
-	protected function execute(InputInterface $input, OutputInterface $output) {
+	protected function execute(InputInterface $input, OutputInterface $output): int {
 		try {
 			$apps = $this->marketService->listApps();
 		} catch (\Exception $ex) {

diff --git a/lib/Command/UnInstallApp.php b/lib/Command/UnInstallApp.php
@@ -51,7 +51,7 @@ protected function configure() {
 			);
 	}
 
-	protected function execute(InputInterface $input, OutputInterface $output) {
+	protected function execute(InputInterface $input, OutputInterface $output): int {
 		if (!$this->marketService->canInstall()) {
 			throw new \Exception("Un-Installing apps is not supported because the app folder is not writable.");
 		}

diff --git a/lib/Command/UpgradeApp.php b/lib/Command/UpgradeApp.php
@@ -79,7 +79,7 @@ protected function configure() {
 	 *
 	 * @throws \Exception
 	 */
-	protected function execute(InputInterface $input, OutputInterface $output) {
+	protected function execute(InputInterface $input, OutputInterface $output): int {
 		if (!$this->marketService->canInstall()) {
 			throw new \Exception("Installing apps is not supported because the app folder is not writable.");
 		}

diff --git a/vendor-bin/phan/composer.json b/vendor-bin/phan/composer.json
@@ -1,5 +1,5 @@
 {
     "require": {
-        "phan/phan": "^5.2"
+        "phan/phan": "^5.4"
     }
 }