Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always return an int from Symfony Command execute method #353

Merged
merged 1 commit into from
May 18, 2023
Merged

Always return an int from Symfony Command execute method #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/Commands/AddClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,10 @@ protected function configure() {
/**
* @param InputInterface $input
* @param OutputInterface $output
* @return int|void
* @return int
* @throws \OCP\AppFramework\Db\MultipleObjectsReturnedException
*/
protected function execute(InputInterface $input, OutputInterface $output) {
protected function execute(InputInterface $input, OutputInterface $output): int {
$name = $input->getArgument('name');
$id = $input->getArgument('client-id');
$secret = $input->getArgument('client-secret');
Expand Down Expand Up @@ -149,5 +149,6 @@ protected function execute(InputInterface $input, OutputInterface $output) {

$this->clientMapper->insert($client);
}
return 0;
}
}
4 changes: 2 additions & 2 deletions lib/Commands/ListClients.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@ protected function configure() {
/**
* @param InputInterface $input
* @param OutputInterface $output
* @return int|void
* @return int
* @throws \OCP\AppFramework\Db\MultipleObjectsReturnedException
*/
protected function execute(InputInterface $input, OutputInterface $output) {
protected function execute(InputInterface $input, OutputInterface $output): int {
$clients = $this->clientMapper->findAll();
$clientsOutput = [];

Expand Down
5 changes: 3 additions & 2 deletions lib/Commands/ModifyClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,10 @@ protected function configure() {
/**
* @param InputInterface $input
* @param OutputInterface $output
* @return int|void
* @return int
* @throws \OCP\AppFramework\Db\MultipleObjectsReturnedException
*/
protected function execute(InputInterface $input, OutputInterface $output) {
protected function execute(InputInterface $input, OutputInterface $output): int {
$name = $input->getArgument('name');
$key = $input->getArgument('key');
$value = $input->getArgument('value');
Expand Down Expand Up @@ -138,5 +138,6 @@ protected function execute(InputInterface $input, OutputInterface $output) {

\call_user_func([$client, $funcMapper[$key]], $value);
$this->clientMapper->update($client);
return 0;
}
}
7 changes: 4 additions & 3 deletions lib/Commands/RemoveClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,18 +54,19 @@ protected function configure() {
* @param InputInterface $input
* @param OutputInterface $output
*
* @return int|void|null
* @return int
* @throws \OCP\AppFramework\Db\MultipleObjectsReturnedException
*/
protected function execute(InputInterface $input, OutputInterface $output) {
protected function execute(InputInterface $input, OutputInterface $output): int {
$id = $input->getArgument('client-id');
try {
$client = $this->clientMapper->findByIdentifier($id);
$this->clientMapper->delete($client);
$output->writeln("Client <$id> has been deleted");
return;
} catch (DoesNotExistException $ex) {
$output->writeln("Client <$id> is unknown");
return 1;
}
return 0;
}
}