Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] [full-ci] Remove Symfony event dispatch from ignoreErrors #492

Merged
merged 1 commit into from
May 23, 2023
Merged

[tests-only] [full-ci] Remove Symfony event dispatch from ignoreErrors #492

merged 1 commit into from
May 23, 2023

Conversation

phil-davis
Copy link
Contributor

Now that core has Symfony5, phpstan no longer complains - good.

Fixes #491

@phil-davis phil-davis requested review from SwikritiT and saw-jan May 23, 2023 09:48
@phil-davis phil-davis self-assigned this May 23, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit acbc490 into master May 23, 2023
@delete-merged-branch delete-merged-branch bot deleted the adjust-for-symfony5 branch May 23, 2023 10:20
@jnweiger jnweiger mentioned this pull request Jul 7, 2023
Closed
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

Assignees

@phil-davis phil-davis

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nightly is failing in phpstan
2 participants
@phil-davis @saw-jan