Easier tls

[jvillafanez]

Make it easier to handle TLS support by using a checkbox instead of auto-detection.

Note that the CA certificate for the LDAP server must be accessible by the ownCloud's LDAP library (the default OS' certificate location should work)

Related: https://github.com/owncloud/enterprise/issues/3721

Quick list of changes:

• Add TLS checkbox
• Remove obsolete "detect port" button and TLS auto-detection
• Include operation timeout option to prevent getting stuck if the CA certificate is missing (if TLS checkbox is enabled)

[codecov]

Codecov Report

Merging #512 into master will increase coverage by 0.8%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master     #512     +/-   ##
===========================================
+ Coverage     35.95%   36.75%   +0.8%     
+ Complexity     1332     1305     -27     
===========================================
  Files            31       31             
  Lines          3780     3700     -80     
===========================================
+ Hits           1359     1360      +1     
+ Misses         2421     2340     -81

Impacted Files	Coverage Δ	Complexity Δ
lib/Controller/WizardController.php	38.15% <ø> (-0.81%)	27 <0> (-1)
lib/Wizard.php	21.94% <100%> (+2.87%)	200 <0> (-26)	⬇️
lib/Connection.php	72.66% <100%> (+0.09%)	110 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce34cd5...f3cf582. Read the comment docs.

[VicDeo]

Fixes #505 ?

[VicDeo]

Looks good

[jvillafanez]

Fixes #505 ?

Yes, as long as he has the certificates to validate the LDAP server. He can also turn off the certificate validation although it's in the advanced tab.
Maybe we should move that "turn off certificate validation" checkbox....

[micbar]

@enbrnz @pako81 @dercorn Please give feedback. There is a recording from JPs demo last friday.

[pako81]

@micbar had a look at the code as well as at the demo from JP. Change makes totally sense so 👍

[micbar]

@jvillafanez please rebase and merge, seems fine