Set core min_version to 10.3 with PHP min of 7.1 #539
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Final decision was to keep 10.4 min version for the app. Thanks anyway @phil-davis and sorry for the noise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could allow user_ldap with core 10.3.2 still, if we want. It should work fine.
It is only #490 "Allow plus in LDAP usernames" that will cause an issue if someone has user_ldap with core 10.3.2 and then does create an LDAP username that contains a
+sign.Note: we should do the
composer.jsonchange at some time anyway. If this PR does not happen, then I will do that tomasterfor some later release.