Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused async #943

Merged
merged 3 commits into from
Sep 24, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Enable lint using rustflags hack
  • Loading branch information
mkeeter committed Sep 24, 2023
commit 94edb6026302541929ec505dfc762494a8cdc040
6 changes: 6 additions & 0 deletions .cargo/config.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
[build]
# Workaround to enable this lint for all packages in the workspace
#
# Once https://github.com/rust-lang/cargo/issues/12115 makes it to our
# toolchain, we'll be able to put this in the `Cargo.toml` manifest instead.
rustflags = ["-Wclippy::unused-async"]
1 change: 0 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
@@ -124,4 +124,3 @@ repair-client = { path = "./repair-client" }

[profile.dev]
panic = 'abort'

1 change: 0 additions & 1 deletion downstairs/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// Copyright 2023 Oxide Computer Company
#![cfg_attr(usdt_need_asm, feature(asm))]
#![cfg_attr(all(target_os = "macos", usdt_need_asm_sym), feature(asm_sym))]
#![warn(clippy::unused_async)]

use futures::executor;
use futures::lock::{Mutex, MutexGuard};
1 change: 0 additions & 1 deletion integration_tests/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
// Copyright 2023 Oxide Computer Company
#![warn(clippy::unused_async)]

#[cfg(test)]
mod test {
1 change: 0 additions & 1 deletion pantry/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
// Copyright 2022 Oxide Computer Company

#![warn(clippy::unused_async)]
use std::sync::Arc;

use anyhow::Result;
1 change: 0 additions & 1 deletion upstairs/src/lib.rs
Original file line number Diff line number Diff line change
@@ -2,7 +2,6 @@
#![cfg_attr(usdt_need_asm, feature(asm))]
#![cfg_attr(all(target_os = "macos", usdt_need_asm_sym), feature(asm_sym))]
#![allow(clippy::mutex_atomic)]
#![warn(clippy::unused_async)]

use std::clone::Clone;
use std::collections::{BTreeSet, HashMap, HashSet, VecDeque};