Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta] add a workspace-hack package managed by hakari #4154

Conversation

sunshowers
Copy link
Contributor

@sunshowers sunshowers commented Sep 27, 2023

Similar to oxidecomputer/crucible#956, this adds
a workspace-hack package managed by cargo-hakari. This should massively
cut down on incremental build times.

cargo hakari doesn't yet support writing out workspace-hack
dependency lines using workspace inheritance
(guppy-rs/guppy#7), so skip over it in the
lint.

Reverting this change can be done by following the instructions at https://docs.rs/cargo-hakari/latest/cargo_hakari/#disabling-and-uninstalling.

Created using spr 1.3.4
Created using spr 1.3.4
Created using spr 1.3.4
Created using spr 1.3.4
Copy link
Collaborator

@smklein smklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm super on-board with this -- the ability to switch between building different packages quickly seems like a huge benefit.

Before merging, I do want to make sure @davepacheco gets a chance to weigh in - I heard you had some prior objections in this space, and I'm interested what they are (and how strongly you feel about them relative to build speed improvements).

@davepacheco
Copy link
Collaborator

I think my previous objections were the stuff mentioned here:
https://docs.rs/cargo-hakari/0.9.27/cargo_hakari/about/index.html#drawbacks (thanks for writing that!)
and particularly the bit about losing track of which workspace packages require which features. But after years of experience with workspace feature resolution issues, if this goes a ways towards addressing that, that'd be a big net win.

@sunshowers
Copy link
Contributor Author

Thanks. I'll land this since there are no conflicts.

Just wanted to reiterate that this change doesn't commit us to the future and can easily be reverted if we run into issues: https://docs.rs/cargo-hakari/latest/cargo_hakari/#disabling-and-uninstalling (though we can also look at fixing any issues we run into, of course).

@sunshowers sunshowers merged commit 8fb68a2 into main Sep 28, 2023
23 checks passed
@sunshowers sunshowers deleted the sunshowers/spr/meta-add-a-workspace-hack-package-managed-by-hakari branch September 28, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants