Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add gtk.enable to home manager instructions #5

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dacid44
Copy link
Contributor

@dacid44 dacid44 commented Nov 6, 2024

When trying to set this up in NixOS, I noticed that you also have to enable GTK management in home manager for the GTK theming to work. This could probably also be solved by instead making the home manager module automatically set gtk.enable = true if the gtk segment is enabled.

@ozwaldorf
Copy link
Owner

I definitely agree, in fact I think the example nixos derivation should probably enable/install all apps that get configureed (at least, the one in the flake, as its built as a ci check and some errors are missed until the app is actually enabled in hm)

@ozwaldorf
Copy link
Owner

ozwaldorf commented Nov 6, 2024

Its a good point though on noting enable must be set in documentation, versus using something like app.enable = lib.mkForce true.

It would probably be more convenient to force enable, but are there any drawbacks or blocked patterns here? I cant think of much reason a user would want to enable the themes and not the app. I'm slightly leaning towards mkforce but curious if you have any thoughts

docs/home.md Show resolved Hide resolved
@dacid44
Copy link
Contributor Author

dacid44 commented Nov 7, 2024

What does mkForce do exactly? I'm still pretty new to Nix and especially to NixOS/home-manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants