Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify CKA_ID in generate-keypair and import-object #615

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

ZoltanFridrich
Copy link
Contributor

@ZoltanFridrich ZoltanFridrich commented Jan 5, 2024

--id option allows users to specify CKA_ID attribute to be associated with imported/generated objects when using p11-kit command. The ID attribute should be specified in hexadecimal format without the "0x" prefix.

Example usage:
p11-kit import-object --file=cert.pem --id="54:62:70:63:f1:75:84:43:58:8e:d1:16:20:b1:c6:ac:1a:bc:f6:89" --label=cert --login "pkcs11:token=test"

Closes #607

@ZoltanFridrich ZoltanFridrich self-assigned this Jan 5, 2024
@coveralls
Copy link

coveralls commented Jan 5, 2024

Coverage Status

coverage: 69.457% (+0.008%) from 69.449%
when pulling ae480ff on ZoltanFridrich:zfridric_devel
into 3fb878a on p11-glue:master.

common/hex.c Show resolved Hide resolved
common/hex.c Outdated Show resolved Hide resolved
common/hex.c Outdated Show resolved Hide resolved
@ZoltanFridrich ZoltanFridrich force-pushed the zfridric_devel branch 3 times, most recently from 5d9c43b to 6a37821 Compare January 9, 2024 15:09
@ZoltanFridrich ZoltanFridrich force-pushed the zfridric_devel branch 2 times, most recently from 60c0aaf to 92cd2bb Compare January 9, 2024 15:17
Copy link
Member

@ueno ueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

common/test-hex.c Outdated Show resolved Hide resolved
@ZoltanFridrich ZoltanFridrich merged commit 2db1b48 into p11-glue:master Jan 10, 2024
14 checks passed
@ZoltanFridrich ZoltanFridrich added this to the 0.25.4 milestone Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

p11-kit generate-keypair should allow setting CKA_ID
3 participants