Add function to check run-time version of the library #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueno
force-pushed
the
wip/dueno/version-api2
branch
from
45c60f7
to
3c9479b
Compare
ueno
force-pushed
the
wip/dueno/version-api2
branch
2 times, most recently
from
3f1f148
to
ad250d8
Compare
ueno
force-pushed
the
wip/dueno/version-api2
branch
from
ad250d8
to
1bbb18c
Compare
ueno
force-pushed
the
wip/dueno/version-api2
branch
from
1bbb18c
to
689e009
Compare
This adds p11_kit_check_version function, which can be used to check the run-time version of p11-kit. Signed-off-by: Daiki Ueno <[email protected]>
ueno
force-pushed
the
wip/dueno/version-api2
branch
from
689e009
to
f3a39ad
Compare
|
Thanks for the review! |
|
Looking at 0.25.5 |
ueno
added a commit
to ueno/p11-kit
that referenced
this pull request
Jul 7, 2024
Previously, version.h was not installed when building with Autotools, and the function symbol was not exposed from libp11-kit when building with Meson. Reported by Andreas Metzler in: p11-glue#637 (comment) Signed-off-by: Daiki Ueno <[email protected]>
ueno
added a commit
to ueno/p11-kit
that referenced
this pull request
Jul 7, 2024
Previously, version.h was not installed when building with Autotools, and the function symbol was not exposed from libp11-kit when building with Meson. Reported by Andreas Metzler in: p11-glue#637 (comment) Signed-off-by: Daiki Ueno <[email protected]>
ueno
added a commit
to ueno/p11-kit
that referenced
this pull request
Jul 7, 2024
Previously, version.h was not installed when building with Autotools, and the function symbol was not exposed from libp11-kit when building with Meson. Reported by Andreas Metzler in: p11-glue#637 (comment) Signed-off-by: Daiki Ueno <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds p11_kit_check_version function, which can be used to check the run-time version of p11-kit.
Fixes: #523