Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/manual: Fix chapter id collision: proxy/sharing #657

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

jca-klk
Copy link
Contributor

@jca-klk jca-klk commented Sep 11, 2024

The chapter id in p11-kit-proxy.xml collides with the one in p11-kit-sharing.xml, which makes the HTML generated page overwriting each other.

This results in duplicate page content for both "Sharing PKCS#11 modules" section and "Proxy Module" section. Both provide content from p11-kit-proxy.xml and make p11-kit-sharing.xml content unavailable to the reader.

Changing the chapter id fixes the issue.

The chapter id in p11-kit-proxy.xml collides with the one in p11-kit-sharing.xml, which makes the HTML generated page overwriting each other.

This results in duplicate page content for both "Sharing PKCS#11 modules" section and "Proxy Module" section. Both provide content from p11-kit-proxy.xml and make p11-kit-sharing.xml content unavailable to the reader.

Changing the chapter id fixes the issue.
Copy link
Member

@ueno ueno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@coveralls
Copy link

Coverage Status

coverage: 69.564% (+0.02%) from 69.542%
when pulling 65f9831 on jca-klk:patch-1
into aedf4d9 on p11-glue:master.

@ueno ueno merged commit 89d3a55 into p11-glue:master Sep 11, 2024
14 checks passed
@jca-klk jca-klk deleted the patch-1 branch September 11, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants