Fixes all kinds of stuff #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requiring this as a module did nothing because there was no way to specify args, that is fixed now. node modules with a command line interface should have a bin field in the package.json file so node can create a shortcut in the node_modules/.bin directory for end user ease of use. That happens now. when specifying -o option on the command line node-jsdoc-toolkit would not output a log file, it would throw an error. Fixing this required a shim for java.io.FileWriter class whose instance would be returned from IO.open. That is done and the output log works now.
node modules with tests should include a scripts.test field that will execute their test suite. This will allow users to run the tests with npm by running npm test. This fixes that.
runs on node, no java required
It's just silly not to have a default template.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially I was just going to fix this so the tests could run on node but then I found a bunch of other bugs and things in the documentation. Check out what I did and merge it if you want to. I've been using it in this state for awhile now and it's doing what I want it to.