Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make our dashboard more contributable #209

Open
1 of 3 tasks
TomasTomecek opened this issue Feb 2, 2023 · 5 comments
Open
1 of 3 tasks

make our dashboard more contributable #209

TomasTomecek opened this issue Feb 2, 2023 · 5 comments
Labels
help-wanted Extra attention is needed.

Comments

@TomasTomecek
Copy link
Member

TomasTomecek commented Feb 2, 2023

yes, contributable is not a word

All our code, deployment recipes, app metadata, and documentation is open. The deployment itself (i.e. the cluster) is not for obvious reasons. Metrics are also not open. Hence we meet criteria for dashboard to be a truly open source service.

Let's make the dashboard more friendly to receive contributions from the public.

Also, provide info on what exact code (git hash) is running.

TODO:

  • dashboard provides info (commit hash, or git tag) of what exact code it's running
  • every page provides a link to how everyone can contribute
  • (optional) create follow-up cards or provide additional ideas or proposals what we can improve
@Venefilyn
Copy link
Collaborator

Venefilyn commented Feb 3, 2023

dashboard provides info (commit hash, or git tag) of what exact code it's running

Commit hash should be easy for dashboard itself. Could display it in the header or bottom of the sidebar. Should this include just the hash for dashboard or also for packit service?

Something like this in top right of the image with a link to the commit?
image

every page provides a link to how everyone can contribute

Like direct to editing or just navigating to the component itself?

@TomasTomecek
Copy link
Member Author

This is a follow-up card to my discussion with @ochosi about what he implemented in Image Builder, just to give context.

It's up to us to decide how exactly we want to follow and what the look and implementation be.

Could display it in the header or bottom of the sidebar.

I'd personally prefer having it in the footer, similar as pagure.io does it.

image

Ultimately, this could even evole to a dedicated page where all versions/tags/hashes would be displayed for the whole stack: dashboard, packit-service, packit...

Like direct to editing or just navigating to the component itself?

I'd just make a single link to a commit in a footer, wouldn't point to components or specific files (in the initial implementation, though this is an interesting suggestion).

@SpyTec what would you suggest?

What are others' thoughts?

@TomasTomecek TomasTomecek added the help-wanted Extra attention is needed. label Feb 6, 2023
@TomasTomecek TomasTomecek moved this from new to backlog in Packit Kanban Board Feb 6, 2023
@Venefilyn
Copy link
Collaborator

Having a footer that is at the bottom of each page seems easy enough. Can show everything we need there

@Venefilyn
Copy link
Collaborator

Having a footer that is at the bottom of each page seems easy enough. Can show everything we need there

Actually. If a page get infinite scrolling that auto fetches the next page we run into the issue of never being able to see the footer, relating to the convo in #211

@TomasTomecek
Copy link
Member Author

Having a footer that is at the bottom of each page seems easy enough. Can show everything we need there

Actually. If a page get infinite scrolling that auto fetches the next page we run into the issue of never being able to see the footer, relating to the convo in #211

true, that's a good point, we'd need to have it somewhere else. In that case, header makes sense as you show it in the mockup above (and we'd finally start using it, noticed only now that it is empty :D)

Venefilyn added a commit to Venefilyn/dashboard that referenced this issue Mar 4, 2023
Within the header there will now be a shorthash visible that links to
packit/dashboard page

Part of packit#209
Venefilyn added a commit to Venefilyn/dashboard that referenced this issue Mar 4, 2023
Within the header there will now be a shorthash visible that links to
packit/dashboard page

Part of packit#209
Venefilyn added a commit to Venefilyn/dashboard that referenced this issue Mar 31, 2023
Within the header there will now be a shorthash visible that links to
packit/dashboard page

Part of packit#209
Venefilyn added a commit to Venefilyn/dashboard that referenced this issue Mar 31, 2023
Within the header there will now be a shorthash visible that links to
packit/dashboard page

Part of packit#209
mfocko pushed a commit that referenced this issue Apr 4, 2023
Within the header there will now be a shorthash visible that links to
packit/dashboard page

Part of #209
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help-wanted Extra attention is needed.
Projects
Status: backlog
Development

No branches or pull requests

2 participants