feat: add commit hash in page header #225
Conversation
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 32s |
Venefilyn
force-pushed
the
feat/commit-hash-in-header
branch
from
a1f51ae
to
ae3fa57
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 29s |
| <PageHeaderTools> | ||
| <Button | ||
| component="a" | ||
| href={`https://github.com/packit/dashboard/commit/${process.env.REACT_APP_GIT_SHA}`} |
| @@ -4,6 +4,8 @@ TEST_IMAGE ?= packit-dashboard-tests | |||
| TEST_TARGET ?= ./tests/ | |||
| CONTAINER_ENGINE ?= $(shell command -v podman 2> /dev/null || echo docker) | |||
| API_STG = "https://stg.packit.dev/api" | |||
| GIT_SHA_FETCH := $(shell git rev-parse HEAD) | |||
There was a problem hiding this comment.
We need to get this logic into the main Dockerfile as this makefile is not used during the image build process
@jpopelka do I get it right?
There was a problem hiding this comment.
Looks like it… I thought we ran Makefile in the dockerfile, but no :/
There was a problem hiding this comment.
I'll check and fix it
Venefilyn
changed the title
Venefilyn
force-pushed
the
feat/commit-hash-in-header
branch
from
ae3fa57
to
ee796f4
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 29s |
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 34s |
Venefilyn
force-pushed
the
feat/commit-hash-in-header
branch
from
c1188f1
to
fd3a26d
Compare
Within the header there will now be a shorthash visible that links to packit/dashboard page Part of packit#209
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 25s |
Signed-off-by: Matej Focko <[email protected]>
|
I hope it's fixed now :) |
Within the header there will now be a shorthash visible that links to packit/dashboard page
Part of #209
TODO:
Fixes
Related to
Merge before/after
RELEASE NOTES BEGIN
Add commit hash for dashboard in page header
RELEASE NOTES END