Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenScanHub response URLs are not in https #2642

Open
1 of 2 tasks
Venefilyn opened this issue Nov 14, 2024 · 2 comments
Open
1 of 2 tasks

OpenScanHub response URLs are not in https #2642

Venefilyn opened this issue Nov 14, 2024 · 2 comments
Labels
area/database Related to the Packit's database complexity/single-task Regular task, should be done within days. gain/low This doesn't bring that much value to users. impact/low This issue impacts only a few users. kind/bug Something isn't working.

Comments

@Venefilyn
Copy link
Contributor

Venefilyn commented Nov 14, 2024

What happened? What is the problem?

Checking the API we get http:// links to OSH instead of https://

What did you expect to happen?

Since OSH redirects anyway it should be https by default

Example URL(s)

See here for links to openscanhub.fedoraproject.org
https://stg.packit.dev/api/osh-scans?page=1

Steps to reproduce

1.
2.
3.

What is the impacted category (job)?

Other

Workaround

  • There is an existing workaround that can be used until this issue is fixed.

Participation

  • I am willing to submit a pull request for this issue. (Packit team is happy to help!)

Depends on openscanhub/fedora-infra#73

@mfocko
Copy link
Member

mfocko commented Nov 18, 2024

Those are the links that we get from the OSH. I don't like this resolving of a problem of different service on our side (we're kinda doing that with Bodhi already…), it's just unnecessary complexity (as if there wasn't enough complexity already…) for Packit.

Please open up an issue against the OpenScanHub, they're open-source project after all…

@Venefilyn
Copy link
Contributor Author

Venefilyn commented Nov 18, 2024

Opened openscanhub/openscanhub#305 to track, if updated we could update packit DB to make it consistent 🙏

@majamassarini majamassarini added area/database Related to the Packit's database complexity/single-task Regular task, should be done within days. impact/low This issue impacts only a few users. gain/low This doesn't bring that much value to users. labels Nov 19, 2024
@majamassarini majamassarini moved this from new to backlog in Packit Kanban Board Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/database Related to the Packit's database complexity/single-task Regular task, should be done within days. gain/low This doesn't bring that much value to users. impact/low This issue impacts only a few users. kind/bug Something isn't working.
Projects
Status: backlog
Development

No branches or pull requests

3 participants