Fedora CI scratch builds #2650
Fedora CI scratch builds #2650
Conversation
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 13s |
| class FedoraCIHelper: | ||
| status_name: str = "Packit - scratch build" |
There was a problem hiding this comment.
I am not sure I understand the need for a new helper.
The KojiBuildJobHelper has some more methods that could be useful when building koji builds that are missing in the generic FedoraCIHelper (if I am not wrong).
If we need the FedoraCIHelper because of the reporting (that is different in Pagure) then I am wondering if we could factor it out in the StatusReporter or somewhere else related with the reporting. And when creating the helpers (that we already have) we can choose which kind of reporter inject?
I just fear that we will need to duplicate all our helpers, creating a new "base".
There was a problem hiding this comment.
yes, at the moment, it really mostly wraps up the status reporting, in my initial implementation it contained some other logic common for the 2 new handlers. So that was the main idea, to have the common logic in here. Other thing is that I didn't want to adjust too much of existing code since this is more of a prototype and might be later changed/moved, therefore I wanted to keep it in one separate place. But having it as it is now, I am ok to just repeat the status reporting logic for the 2 handlers.
There was a problem hiding this comment.
It does not need to be done now, but I agree with Maja that we should be cautious about adding more helpers. (TBH, I don't think this was a good idea when introducing them... yes, I am probably the one to blame..;)
lbarcziova
force-pushed
the
fedora-ci-scratch-builds
branch
from
7fe919f
to
7cf32b5
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 07s |
lbarcziova
force-pushed
the
fedora-ci-scratch-builds
branch
from
7cf32b5
to
110a4f9
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 08s |
For the prototype for packit#2602. This will be likely moved/adjusted later. For now mostly for testing this ourselves, we decided to run the jobs just for the projects defined in our service config. No package configuration is needed.
So that it can be used for both upstream and downstream reporting.
lbarcziova
force-pushed
the
fedora-ci-scratch-builds
branch
from
110a4f9
to
3c67e54
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 14s |
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 2m 15s |
softwarefactory-project-zuul
bot
merged commit b06de6a
into
packit:main
| @@ -104,6 +107,30 @@ def _add_to_mapping(kls: type["JobHandler"]): | |||
| return _add_to_mapping | |||
|
|
|||
|
|
|||
| def reacts_to_as_fedora_ci(event: type["Event"]): | |||
| class FedoraCIHelper: | ||
| status_name: str = "Packit - scratch build" |
There was a problem hiding this comment.
It does not need to be done now, but I agree with Maja that we should be cautious about adding more helpers. (TBH, I don't think this was a good idea when introducing them... yes, I am probably the one to blame..;)
Related to #2602
RELEASE NOTES BEGIN
N/A
RELEASE NOTES END